[release-v0.37.x] Fix the issue with empty array replacement

[vdemeester]

Changes

This backports #5162 that fixes #5149 as it also affects 0.37.x.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

After the replacement with an empty array, the original array will be empty.

Example:
---
params:
  - name: myarray
     value: "$(params.anEmptyArray[*])"

/cc @abayer @afrittoli @lbernick @jerop

[vdemeester]

/kind bug

[abayer]

/approve

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	98.1%	97.4%	-0.7

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abayer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	98.1%	97.4%	-0.7
pkg/pod/creds_init.go	93.9%	93.3%	-0.5

[lbernick]

What's the commit with "nosec"? Is that supposed to be in there?

[abayer]

What's the commit with "nosec"? Is that supposed to be in there?

It's just making golangci-lint be quiet about something we don't care about that's only showing up now because we're using a newer golangci-lint in the test-runner image now than we were at the time of the v0.37.0 release. I already dealt with it on main earlier this month.

[lbernick]

/lgtm

[afrittoli]

/cherrypick release-v0.36.x

[tekton-robot]

@afrittoli: new pull request created: #5442

In response to this:

/cherrypick release-v0.36.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.