Remove deprecated flags home-env and working-dir 🧹

config/config-feature-flags.yaml

@@ -30,18 +30,6 @@ data:
   # https://github.com/tektoncd/pipeline/blob/main/docs/workspaces.md#affinity-assistant-and-specifying-workspace-order-in-a-pipeline
   # or https://github.com/tektoncd/pipeline/pull/2630 for more info.
   disable-affinity-assistant: "false"
-  # Setting this flag to "false" will allow Tekton to override your
-  # Task container's $HOME environment variable.
-  #
-  # See https://github.com/tektoncd/pipeline/issues/2013 for more
-  # info.
-  disable-home-env-overwrite: "true"
-  # Setting this flag to "false" will allow Tekton to override your
-  # Task container's working directory.
-  #
-  # See https://github.com/tektoncd/pipeline/issues/1836 for more
-  # info.
-  disable-working-directory-overwrite: "true"
   # Setting this flag to "true" will prevent Tekton scanning attached
   # service accounts and injecting any credentials it finds into your
   # Steps.

docs/deprecations.md

@@ -23,7 +23,5 @@ being deprecated.
 | [The `TaskRun.Status.ResourceResults.ResourceRef` field is deprecated and will be removed.](https://github.com/tektoncd/pipeline/issues/2694)                       | [v0.14.0](https://github.com/tektoncd/pipeline/releases/tag/v0.14.0) | Beta                                                                                                   | April 30 2021                       |
 | [The `PipelineRun.Spec.ServiceAccountNames` field is deprecated and will be removed.](https://github.com/tektoncd/pipeline/issues/2614)                             | [v0.15.0](https://github.com/tektoncd/pipeline/releases/tag/v0.15.0) | Beta                                                                                                   | May 15 2021                         |
 | [`Conditions` CRD is deprecated and will be removed. Use `when` expressions instead.](https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md) | [v0.16.0](https://github.com/tektoncd/pipeline/releases/tag/v0.16.0) | Alpha                                                                                                  | Nov 02 2020                         |
-| [The `disable-home-env-overwrite` flag will be removed](https://github.com/tektoncd/pipeline/issues/2013)                                                           | [v0.24.0](https://github.com/tektoncd/pipeline/releases/tag/v0.24.0) | Beta                                                                                                   | February 10 2022                    |
-| [The `disable-working-dir-overwrite` flag will be removed](https://github.com/tektoncd/pipeline/issues/1836)                                                        | [v0.24.0](https://github.com/tektoncd/pipeline/releases/tag/v0.24.0) | Beta                                                                                                   | February 10 2022                    |
 | [The `scope-when-expressions-to-task` flag will be removed](https://github.com/tektoncd/pipeline/issues/4461)                                                       | [v0.27.0](https://github.com/tektoncd/pipeline/releases/tag/v0.27.0) | Beta                                                                                                   | March 10 2022                       |
 | [`PipelineResources` are deprecated.](https://github.com/tektoncd/community/blob/main/teps/0074-deprecate-pipelineresources.md)                                     | [v0.30.0](https://github.com/tektoncd/pipeline/releases/tag/v0.30.0) | Alpha                                                                                                  | Dec 20 2021                         |

docs/install.md

@@ -338,14 +338,6 @@ To customize the behavior of the Pipelines Controller, modify the ConfigMap `fea
   node in the cluster must have an appropriate label matching `topologyKey`. If some or all nodes
   are missing the specified `topologyKey` label, it can lead to unintended behavior.
 
-- `disable-home-env-overwrite` - set this flag to `false` to allow Tekton
-to override the `$HOME` environment variable for the containers executing your `Steps`.
-The default is `true`. For more information, see the [associated issue](https://github.com/tektoncd/pipeline/issues/2013).
-
-- `disable-working-directory-overwrite` - set this flag to `false` to allow Tekton
-to override the working directory for the containers executing your `Steps`.
-The default value is `true`. For more information, see the [associated issue](https://github.com/tektoncd/pipeline/issues/1836).
-
 - `running-in-environment-with-injected-sidecars`: set this flag to `"true"` to allow the
 Tekton controller to set the `tekton.dev/ready` annotation at pod creation time for
 TaskRuns with no Sidecars specified. Enabling this option should decrease the time it takes for a TaskRun to
@@ -389,8 +381,6 @@ kind: ConfigMap
 metadata:
   name: feature-flags
 data:
-  disable-home-env-overwrite: "true" # Tekton will not override the $HOME variable for individual Steps.
-  disable-working-directory-overwrite: "true" # Tekton will not override the working directory for individual Steps.
   enable-api-fields: "alpha" # Allow alpha fields to be used in Tasks and Pipelines.
 ```
 

pkg/apis/config/feature_flags.go

@@ -30,10 +30,6 @@ const (
 	StableAPIFields = "stable"
 	// AlphaAPIFields is the value used for "enable-api-fields" when alpha APIs should be usable as well.
 	AlphaAPIFields = "alpha"
-	// DefaultDisableHomeEnvOverwrite is the default value for "disable-home-env-overwrite".
-	DefaultDisableHomeEnvOverwrite = true
-	// DefaultDisableWorkingDirOverwrite is the default value for "disable-working-directory-overwrite".
-	DefaultDisableWorkingDirOverwrite = true
 	// DefaultDisableAffinityAssistant is the default value for "disable-affinity-assistant".
 	DefaultDisableAffinityAssistant = false
 	// DefaultDisableCredsInit is the default value for "disable-creds-init".
@@ -51,8 +47,6 @@ const (
 	// DefaultEnableAPIFields is the default value for "enable-api-fields".
 	DefaultEnableAPIFields = StableAPIFields
 
-	disableHomeEnvOverwriteKey          = "disable-home-env-overwrite"
-	disableWorkingDirOverwriteKey       = "disable-working-directory-overwrite"
 	disableAffinityAssistantKey         = "disable-affinity-assistant"
 	disableCredsInitKey                 = "disable-creds-init"
 	runningInEnvWithInjectedSidecarsKey = "running-in-environment-with-injected-sidecars"
@@ -66,8 +60,6 @@ const (
 // FeatureFlags holds the features configurations
 // +k8s:deepcopy-gen=true
 type FeatureFlags struct {
-	DisableHomeEnvOverwrite          bool
-	DisableWorkingDirOverwrite       bool
 	DisableAffinityAssistant         bool
 	DisableCredsInit                 bool
 	RunningInEnvWithInjectedSidecars bool
@@ -103,12 +95,6 @@ func NewFeatureFlagsFromMap(cfgMap map[string]string) (*FeatureFlags, error) {
 	}
 
 	tc := FeatureFlags{}
-	if err := setFeature(disableHomeEnvOverwriteKey, DefaultDisableHomeEnvOverwrite, &tc.DisableHomeEnvOverwrite); err != nil {
-		return nil, err
-	}
-	if err := setFeature(disableWorkingDirOverwriteKey, DefaultDisableWorkingDirOverwrite, &tc.DisableWorkingDirOverwrite); err != nil {
-		return nil, err
-	}
 	if err := setFeature(disableAffinityAssistantKey, DefaultDisableAffinityAssistant, &tc.DisableAffinityAssistant); err != nil {
 		return nil, err
 	}

pkg/apis/config/feature_flags_test.go

@@ -35,8 +35,6 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 	testCases := []testCase{
 		{
 			expectedConfig: &config.FeatureFlags{
-				DisableHomeEnvOverwrite:          false,
-				DisableWorkingDirOverwrite:       false,
 				RunningInEnvWithInjectedSidecars: config.DefaultRunningInEnvWithInjectedSidecars,
 				ScopeWhenExpressionsToTask:       config.DefaultScopeWhenExpressionsToTask,
 				EnableAPIFields:                  "stable",
@@ -45,8 +43,6 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 		},
 		{
 			expectedConfig: &config.FeatureFlags{
-				DisableHomeEnvOverwrite:          true,
-				DisableWorkingDirOverwrite:       true,
 				DisableAffinityAssistant:         true,
 				RunningInEnvWithInjectedSidecars: false,
 				RequireGitSSHSecretKnownHosts:    true,
@@ -65,8 +61,6 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 				EnableTektonOCIBundles: true,
 				EnableCustomTasks:      true,
 
-				DisableHomeEnvOverwrite:          true,
-				DisableWorkingDirOverwrite:       true,
 				RunningInEnvWithInjectedSidecars: config.DefaultRunningInEnvWithInjectedSidecars,
 				ScopeWhenExpressionsToTask:       config.DefaultScopeWhenExpressionsToTask,
 			},
@@ -78,8 +72,6 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 				EnableTektonOCIBundles: true,
 				EnableCustomTasks:      true,
 
-				DisableHomeEnvOverwrite:          true,
-				DisableWorkingDirOverwrite:       true,
 				RunningInEnvWithInjectedSidecars: config.DefaultRunningInEnvWithInjectedSidecars,
 				ScopeWhenExpressionsToTask:       config.DefaultScopeWhenExpressionsToTask,
 			},
@@ -99,8 +91,6 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 func TestNewFeatureFlagsFromEmptyConfigMap(t *testing.T) {
 	FeatureFlagsConfigEmptyName := "feature-flags-empty"
 	expectedConfig := &config.FeatureFlags{
-		DisableHomeEnvOverwrite:          true,
-		DisableWorkingDirOverwrite:       true,
 		RunningInEnvWithInjectedSidecars: true,
 		ScopeWhenExpressionsToTask:       config.DefaultScopeWhenExpressionsToTask,
 		EnableAPIFields:                  "stable",

pkg/apis/config/testdata/feature-flags-all-flags-set.yaml

@@ -18,8 +18,6 @@ metadata:
   name: feature-flags
   namespace: tekton-pipelines
 data:
-  disable-home-env-overwrite: "true"
-  disable-working-directory-overwrite: "true"
   disable-affinity-assistant: "true"
   running-in-environment-with-injected-sidecars: "false"
   require-git-ssh-secret-known-hosts: "true"

pkg/apis/config/testdata/feature-flags.yaml

@@ -18,8 +18,6 @@ metadata:
   name: feature-flags
   namespace: tekton-pipelines
 data:
-  disable-home-env-overwrite: "false"
-  disable-working-directory-overwrite: "false"
   disable-affinity-assistant: "false"
   running-in-environment-with-injected-sidecars: "true"
   require-git-ssh-secret-known-hosts: "false"