Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated flags home-env and working-dir 🧹 #4587

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Remove deprecated flags home-env and working-dir 🧹 #4587

merged 1 commit into from
Feb 16, 2022

Conversation

afrittoli
Copy link
Member

@afrittoli afrittoli commented Feb 16, 2022 •
edited
Loading

Changes

This change removes two flags:

  • disable-home-env-overwrite
  • disable-working-dir-overwrite

That two flags that were originally introduced with default to false
and the feature associated to them was deprecated.
Nine months later (as per policy), in Dec 2020, the default value was
switched to default true and the flags were deprecated. Nine months
later we are finally removing the flags.

Fixes: #1836
Fixes: #2013

Signed-off-by: Andrea Frittoli [email protected]

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

The configuration flags `disable-working-dir-overwrite` and `disable-home-env-overwrite`, after defaulting
to `True` for nine months (i.e. feature disabled), have now been removed completely, along with the associated
features which are not available in Tekton anymore.

@afrittoli
Remove deprecated flags home-env and working-dir
c436b1b 
This change removes two flags:

- disable-home-env-overwrite
- disable-working-dir-overwrite

That two flags that were originally introduced with default to false
and the feature associated to them was deprecated.
Nine months later (as per policy), in Dec 2020, the default value was
switched to default true and the flags were deprecated. Nine months
later we are finally removing the flags.

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 16, 2022
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2022
@afrittoli afrittoli added this to the Pipelines v0.33 milestone Feb 16, 2022
@afrittoli
Copy link
Member Author

Related to #2013

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 84.4% 87.8% 3.4

@afrittoli afrittoli requested a review from a user February 16, 2022 18:04
@ghost
Copy link

ghost commented Feb 16, 2022

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 16, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022
pritidesai
pritidesai approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @afrittoli 🎉

I am guessing the release notes are sufficient here to announce this since the release notes will also make it under the Pipelines release announcements.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@tekton-robot tekton-robot merged commit 2b731fb into tektoncd:main Feb 16, 2022
@afrittoli
Copy link
Member Author

thank you @afrittoli 🎉

I am guessing the release notes are sufficient here to announce this since the release notes will also make it under the Pipelines release announcements.

Thanks @pritidesai , I'll make sure to highlight it in the release notes "backward incompatible changes" section :)

@lbernick lbernick mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.33
3 participants
@afrittoli @tekton-robot @pritidesai