Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where workspace volume variable and pod volume conf differ #3315

Merged
merged 1 commit into from Oct 2, 2020
Merged

Fix issue where workspace volume variable and pod volume conf differ #3315

merged 1 commit into from Oct 2, 2020

Commits on Oct 1, 2020

  1. Fix issue where workspace volume variable and pod volume conf differ 

    Prior to this commit the volumes that were generated for workspace bindings
did not have names that matched the values injected through
workspaces.<name>.volume variables. This occurred because we called
the GetVolumes workspace function twice during TaskRun Pod initialization and
each execution generated different random names.

This commit updates the TaskRun reconciler to generate the random volume
names only once and then pass those generated volumes to the two functions
that need them. Additionally the function generating those volumes is renamed
to make clear that volume creation is its purpose. A e2e test is added to
ensure that the workspace volume and variable value matches.
    Scott committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    531a14d View commit details
    Browse the repository at this point in the history