Fix issue where workspace volume variable and pod volume conf differ #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the volumes that were generated for workspace bindings did not have names that matched the values injected through workspaces.<name>.volume variables. This occurred because we called the GetVolumes workspace function twice during TaskRun Pod initialization and each execution generated different random names. This commit updates the TaskRun reconciler to generate the random volume names only once and then pass those generated volumes to the two functions that need them. Additionally the function generating those volumes is renamed to make clear that volume creation is its purpose. A e2e test is added to ensure that the workspace volume and variable value matches.
ghost
added
the
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
pritidesai
reviewed
Oct 2, 2020
| volumeNames := []string{} | ||
| for _, volume := range p.Spec.Volumes { | ||
| if volume.Name == workspaceVariableValue { | ||
| return |
There was a problem hiding this comment.
the idea here is to declare a test success once volume name matches with the workspace from containers args list. Without such match, test would fail with error on 318, took a little bit of reading to understand 😜
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3312
Prior to this commit the volumes that were generated for workspace bindings did not have names that matched the values injected through
workspaces.<name>.volumevariables. This occurred because we called the GetVolumes workspace function twice during TaskRun Pod initialization and each execution generated different random names.This commit updates the TaskRun reconciler to generate the random volume names only once and then pass those generated volumes to the two functions that need them. Additionally the function generating those volumes is renamed to make clear that volume creation is its purpose. A e2e test is added to ensure that the workspace volume and variable value matches.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes