Enhance v1beta1 validation code for pipeline 🍸 #3277
Conversation
tekton-robot
requested review from
bobcatfish,
imjasonh,
jerop,
pritidesai,
savitaashture and
a user
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
vdemeester
force-pushed
the
enhance-pipeline-validation
branch
from
387fd4b
to
734861f
Compare
|
The following is the coverage report on the affected files.
|
|
|
||
| return nil | ||
| errs = errs.Also(validatePipelineResults(ps.Results)) | ||
| errs = errs.Also(validateTasksAndFinallySection(ps)) |
There was a problem hiding this comment.
This is a bit duplicated (in some weird way) with the task validation above. The whole task and finally validation code could be enhanced in follow-ups
| // Task names are appended to the container name, which must exist and | ||
| // must be a valid k8s name | ||
| if errSlice := validation.IsQualifiedName(t.Name); len(errSlice) != 0 { | ||
| return apis.ErrInvalidValue(strings.Join(errSlice, ","), fmt.Sprintf(prefix+"[%d].name", i)) | ||
| } |
There was a problem hiding this comment.
This is less strict than validatePipelineTaskName so we don't really need to do it, at all
vdemeester
force-pushed
the
enhance-pipeline-validation
branch
from
734861f
to
2979f0c
Compare
|
The following is the coverage report on the affected files.
|
This make a better use of knative.dev/pkg apis errors package in order to make the code simpler, *and* the report better. - This allows reporting multiple validation error at once — so, one failure message (webhook error) would be more useful to the user. - This reduce `if err != nil` path, simplifying the code. This commit tackles `Pipeline` 🙃 Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
enhance-pipeline-validation
branch
from
2979f0c
to
494bbbd
Compare
|
The following is the coverage report on the affected files.
|
| func TestPipelineSpec_Validate_Failure_CycleDAG(t *testing.T) { | ||
| name := "invalid pipeline spec with DAG having cyclic dependency" | ||
| ps := &PipelineSpec{ | ||
| Tasks: []PipelineTask{{ | ||
| Name: "foo", TaskRef: &TaskRef{Name: "foo-task"}, RunAfter: []string{"bar"}, | ||
| }, { | ||
| Name: "bar", TaskRef: &TaskRef{Name: "bar-task"}, RunAfter: []string{"foo"}, | ||
| }}, | ||
| } | ||
| err := ps.Validate(context.Background()) | ||
| if err == nil { | ||
| t.Errorf("PipelineSpec.Validate() did not return error for invalid pipelineSpec: %s", name) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Extracted this to not have a flaky unit test. We do validate it errors out but not checking the error as the order is not deterministic (can be foo -> bar -> foo or bar -> foo -> bar, both make senses).
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Yeah indeed. I'll try to make an issue on tech dept in there (and other |
Changes
This make a better use of knative.dev/pkg apis errors package in order
to make the code simpler, and the report better.
failure message (webhook error) would be more useful to the user.
if err != nilpath, simplifying the code.This commit tackles
Pipeline🙃Signed-off-by: Vincent Demeester [email protected]
/cc @pritidesai @jerop @bobcatfish @sbwsg @savitaashture @imjasonh
/kind cleanup
/hold
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes