Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance v1beta1 validation code for pipeline 🍸 #3277

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Enhance v1beta1 validation code for pipeline 🍸 #3277

merged 1 commit into from
Sep 23, 2020

Commits on Sep 23, 2020

  1. Enhance v1beta1 validation code for pipeline 🍸 

    This make a better use of knative.dev/pkg apis errors package in order
to make the code simpler, *and* the report better.

- This allows reporting multiple validation error at once — so, one
  failure message (webhook error) would be more useful to the user.
- This reduce `if err != nil` path, simplifying the code.

This commit tackles `Pipeline` 🙃

Signed-off-by: Vincent Demeester <[email protected]>
    @vdemeester
    vdemeester committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    494bbbd View commit details
    Browse the repository at this point in the history