Improve display of skipped tasks #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
AlanGreene
force-pushed
the
when-expressions
branch
2 times, most recently
from
a5cdeb6
to
f442079
Compare
tekton-robot
added
size/L
AlanGreene
force-pushed
the
when-expressions
branch
from
f442079
to
3eac713
Compare
|
/test all |
AlanGreene
force-pushed
the
when-expressions
branch
from
3eac713
to
29ae602
Compare
tekton-robot
added
size/XL
|
/test all |
AlanGreene
force-pushed
the
when-expressions
branch
2 times, most recently
from
941d171
to
39fc8a3
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
AlanGreene
force-pushed
the
when-expressions
branch
from
39fc8a3
to
6b21f54
Compare
packages/components/src/components/DetailsHeader/DetailsHeader.jsx
Outdated
Show resolved
Hide resolved
When a task is skipped ensure this is communicated to the user instead of leaving it showing as 'pending'. In the case of when expressions, surface details of the when expression so the user can undertsand the reason for the task being skipped. Also remove elements that will never have content in this case such as the pod tab on the TaskRun details view, and replace the log container with a message indicating that the task was skipped and no logs will be available. Update the status icons and labels to differentiate between pending / not run and skipped. Apply similar changes for step-level when expressions which rely on the step actions feature being enabled.
AlanGreene
force-pushed
the
when-expressions
branch
from
6b21f54
to
02c864d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
This was referenced Oct 22, 2024
AlanGreene
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note
This PR addresses a current gap in functionality, surfacing important information to the user to help understand the behaviour of a given pipeline / pipeline run.
It is a work in progress of one potential tactical change to improve the display of skipped tasks in the short term.
The design and/or approach may change drastically before it is merged.
However, a much larger and far-reaching redesign of the PipelineRun details page is still planned, see #2306 for details of some of the identified aspects. That change will likely involve updates to the navigation structure of the task list, the display of logs, and may also impact the way the 'skipped' status is surfaced.
Resolves #2293
Resolves #1445
When a task is skipped ensure this is communicated to the user instead of leaving it showing as 'pending'.
In the case of when expressions, surface details of the when expression so the user can undertsand the reason for the task being skipped. Also remove elements that will never have content in this case such as the pod tab on the TaskRun details view, and replace the log container with a message indicating that the task was skipped and no logs will be available.
Update the status icons and labels to differentiate between pending / not run and skipped.
Apply similar changes for step-level when expressions which rely on the step actions feature being enabled.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes