Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped tasks shown as pending #2293

Closed
larhauga opened this issue Jan 21, 2022 · 8 comments · Fixed by #3651
Closed

Skipped tasks shown as pending #2293

larhauga opened this issue Jan 21, 2022 · 8 comments · Fixed by #3651
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@larhauga
Copy link

Describe the bug

Pipelines with tasks that are skipped (like due to non master branch run) is observed to have the state of pending even though it has been skipped. This issue came to us from end-users, which did not understand why the task was still pending.

image

Expected behaviour

We expect the status of the skipped task to be Skipped; not Pending.

Steps to reproduce the bug

In this case we have a when condition, that skipps this task if branch is main or master.

...
    - name: promote
      runAfter:
      - mvn-build
      taskRef:
        kind: ClusterTask
        name: # taskname
      when:
      - input: $(params.gitbranchname)
        operator: in
        values:
        - master
        - main
...

Environment details

  • Kubernetes Platform: EKS
  • Kubernetes or OpenShift version: 1.21
  • Install mode (if on OpenShift): no
  • Cloud-provider/provisioner: EKS
  • Versions:
    • Tekton Dashboard: 0.23.0
    • Tekton Pipelines: 0.31.0
    • Tekton Triggers: 0.18.0
  • Install namespaces:
    • Tekton Dashboard: tekton-pipelines
    • Tekton Pipelines:
    • Tekton Triggers:

Additional Info

@larhauga larhauga added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2022
@AlanGreene
Copy link
Member

AlanGreene commented Jan 22, 2022

Thanks for raising this issue @larhauga. We're currently considering a redesign of this page to improve display of a number of things including when expressions, retries, and more.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2022
@AlanGreene
Copy link
Member

AlanGreene commented Apr 23, 2022

This is something we'll be addressing as part of the PipelineRun details page redesign which is currently in progress. Freezing so it doesn't get auto closed.

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 23, 2022
@AlanGreene
Copy link
Member

When we address this we should review tektoncd/pipeline#4829 and TEP-0103. This makes additional useful information available regarding the reason for a task being skipped.

@AlanGreene
Copy link
Member

Hoping to revisit this soon. Related to #1445

@AlanGreene
Copy link
Member

Blocked by #3493 which in currently is progress. It affects pretty much the entire front-end codebase so we've paused functional changes util that's complete, ETA ~end of month.

Once that's done, this is among the next batch of UI updates planned.

@AlanGreene
Copy link
Member

#3651 improves the display of skipped tasks, making it clearer to users that these are skipped and not actually pending. The corresponding when expression or other relevant reason is displayed in the taskrun status, and the log container clearly identifies that no logs will be displayed due to the task being skipped.

This will be available in the next nightly release, and included in Dashboard v0.52.0 which is expected in the next week or so.

Further improvements will be made as part of #2306

@AlanGreene
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants