Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --keep and --keep-since together in tr/pr delete #1533

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Support --keep and --keep-since together in tr/pr delete #1533

merged 2 commits into from
Apr 5, 2022

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Mar 15, 2022 •
edited
Loading

While deleting a TaskRun/PipelineRun, this adds support of
using --keep and --keep-since together.

Also fix pipelineRun/Taskrun deletion when few pr/tr is in
running state and --keep-since is used along with --ignore-running=false
Closes: #1471 #1552

Signed-off-by: divyansh42 [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Support --keep and --keep-since together in tkn tr delete/ tkn pr delete

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 15, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from bc301c2 to 4ce8971 Compare March 15, 2022 15:29
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from 4ce8971 to b71844d Compare March 15, 2022 15:35
@divyansh42 divyansh42 marked this pull request as draft March 15, 2022 15:37
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from b71844d to e9f5a5b Compare March 15, 2022 15:43
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2022
@divyansh42 divyansh42 marked this pull request as ready for review March 15, 2022 15:45
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@vinamra28
Copy link
Member

/retest

vinamra28
vinamra28 reviewed Mar 15, 2022
View reviewed changes
@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from e9f5a5b to 3e4f06d Compare March 29, 2022 17:25
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from 3e4f06d to 6044d6a Compare March 29, 2022 17:30
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/delete.go 90.9% 90.3% -0.6
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42
Support --keep and --keep-since together in tr delete
8172770 
While deleting a taskrun, this adds support of
using --keep and --keep-since together

Signed-off-by: divyansh42 <[email protected]>
@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from 6044d6a to f85429b Compare March 31, 2022 18:53
@divyansh42 divyansh42 force-pushed the keep-and-keep-since branch from f85429b to 6261eba Compare March 31, 2022 18:55
@divyansh42 divyansh42 changed the title Support --keep and --keep-since together in tr delete Support --keep and --keep-since together in tr/pr delete Mar 31, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/delete.go 92.3% 90.9% -1.3
pkg/cmd/taskrun/delete.go 90.9% 89.8% -1.2
pkg/options/delete.go 93.8% 97.1% 3.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/delete.go 92.3% 90.9% -1.3
pkg/cmd/taskrun/delete.go 90.9% 89.8% -1.2
pkg/options/delete.go 93.8% 97.1% 3.3

@divyansh42 divyansh42 requested a review from vinamra28 April 1, 2022 03:05
vinamra28
vinamra28 reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@tekton-robot tekton-robot merged commit 114c5ee into tektoncd:main Apr 5, 2022
pradeepitm12 added a commit that referenced this pull request Jun 6, 2022
@pradeepitm12
New version v0.24.0
a0d672a 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 6, 2022
@pradeepitm12
New version v0.24.0
108c443 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 6, 2022
@pradeepitm12
New version v0.24.0
613b95d 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 6, 2022
@pradeepitm12
New version v0.24.0
6b6f2b7 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 6, 2022
@pradeepitm12
New version v0.24.0
fbe0f5a 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 7, 2022
@pradeepitm12
New version v0.24.0
7ec7aef 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03
null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46
null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 7, 2022
@pradeepitm12
New version v0.24.0
d5f9dba 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03
null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46
null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 7, 2022
@pradeepitm12
New version v0.24.0
2c7fec2 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03
null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46
null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11
null | [Pradeep Kumar] fix unit-test in release pipeline | 2022/06/07-08:24

Signed-off-by: Pradeep Kumar <[email protected]>
pradeepitm12 added a commit that referenced this pull request Jun 7, 2022
@pradeepitm12
New version v0.24.0
fc02d2a 
#1544 | [Pradeep Kumar] update version in readme to v0.23.1 | 2022/03/25-15:26
#1545 | [Piyush Garg] Bump choco spec to v0.23.1 | 2022/03/25-17:50
#1535 | [Chmouel Boudjnah] Add available plugins to the root help | 2022/03/29-13:26
null | [Vincent Demeester] Update ROADMAP.md | 2022/03/30-16:15
#1533 | [divyansh42] Support --keep and --keep-since together in tr delete | 2022/04/05-16:44
#1533 | [divyansh42] Support --keep and --keep-since together in pr delete | 2022/04/05-16:44
#1556 | [vinamra28] Use stable pipelines release instead of nightly | 2022/04/12-14:12
#1554 | [vinamra28] Cancel PipelineRuns using Cancelled status | 2022/04/12-15:16
#1555 | [Vincent Demeester] Bump docker/docker and docker/cli dependencies | 2022/04/13-07:49
#1555 | [Vincent Demeester] Bump containerd/containerd | 2022/04/13-07:49
null | [pratap0007] Fixes pipelinerun and taskrun deletion with keep flag | 2022/04/15-06:49
null | [Piyush Garg] Add vinamra28 as owner | 2022/04/28-12:47
null | [vinamra28] Fix Pipeline integration tests | 2022/05/10-13:41
null | [Zhu Sheng Li] fix: set created time for bundle image | 2022/05/11-03:49
null | [vinamra28] Revert skipping of failed test | 2022/05/16-07:26
null | [Pradeep Kumar] dep bumps | 2022/06/01-17:24
null | [Pradeep Kumar] fix go test | 2022/06/01-17:24
null | [Vincent Demeester] Add dependabot to the repository | 2022/06/02-11:25
null | [Shubham] Set go mod compat to 1.17 | 2022/06/03-15:45
null | [Shubham] Bump chains to v0.9.0 in go.mod, go.sum | 2022/06/03-15:45
null | [Shubham] ./hack/update-deps.sh | 2022/06/03-15:45
null | [Shubham] Fix chains impl per 0.9.0 update | 2022/06/03-15:45
null | [Shubham] Replace xerrors.Errorf with fmt.Errorf | 2022/06/03-15:45
null | [Shubham] go mod tidy -go=1.16 && go mod tidy -go=1.17 | 2022/06/03-15:45
null | [Shubham] Get rid of antlr | 2022/06/03-15:45
null | [Shubham] Improve `tkn chain` log format | 2022/06/06-06:58
null | [Piyush Garg] Fix --ignore-running not working with -p/-t in delete cmd | 2022/06/06-08:19
null | [Shubham] Ignore zap logger sync error | 2022/06/06-08:19
null | [Vincent Demeester] Add label dependabot PRs ok-to-test… | 2022/06/06-09:03
null | [Pradeep Kumar] update release script compatible with go 1.17 | 2022/06/06-14:46
null | [Shubham] Fix `tkn chains signature/payload` by version bump | 2022/06/07-06:11
null | [Pradeep Kumar] fix unit-test in release pipeline | 2022/06/07-08:24
null | [Pradeep Kumar] increase storage to 1Gi | 2022/06/07-10:46

Signed-off-by: Pradeep Kumar <[email protected]>
@piyush-garg piyush-garg mentioned this pull request Aug 9, 2022
Closed
4 tasks
@avinal avinal mentioned this pull request Aug 10, 2022
Closed
avinal added a commit to avinal/operator that referenced this pull request Aug 29, 2022
@avinal
Define keep and keep-since simultaneously
9213dce 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
@avinal avinal mentioned this pull request Aug 29, 2022
Merged
4 tasks
avinal added a commit to avinal/operator that referenced this pull request Aug 30, 2022
@avinal
Define keep and keep-since simultaneously
da5694c 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this pull request Sep 2, 2022
@avinal
Define keep and keep-since simultaneously
3bb7ca5 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this pull request Oct 17, 2022
@avinal
Define keep and keep-since simultaneously
f24cd60 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this pull request Dec 26, 2022
@avinal
Define keep and keep-since simultaneously
6760e4a 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this pull request Dec 27, 2022
@avinal
Define keep and keep-since simultaneously
fa22307 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
tekton-robot pushed a commit to tektoncd/operator that referenced this pull request Dec 29, 2022
@avinal @tekton-robot
Define keep and keep-since simultaneously
712ba2d 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes #974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
@piyush-garg piyush-garg mentioned this pull request Dec 29, 2022
Closed
4 tasks
@jkandasa jkandasa mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support --keep and --keep-since together
5 participants
@divyansh42 @tekton-robot @vinamra28 @vdemeester @pradeepitm12