Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support --keep and --keep-since together #1471

Closed
pradeepitm12 opened this issue Nov 23, 2021 · 3 comments · Fixed by #1533
Closed

support --keep and --keep-since together #1471

pradeepitm12 opened this issue Nov 23, 2021 · 3 comments · Fixed by #1533
Assignees
@divyansh42
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
0.23.0

Comments

@pradeepitm12
Copy link
Contributor

Feature request

tkn to support --keep and --keep-since flags together while deleting a pipelinerun or a taskrun.

Use case

--keep=x is used to delete all taskrun/pipelinerun except for the x latest.
where as
--keep-since=x is used to delete the taskrun/pipelinerun older x minutes.
There are scenarios when user would like to delete all the taskrun/pipelinerun older x minutes keeping y max.
e.g.
I have 1000 pipelineruns that are older than 5mins and 100 younger than it, I would like to delete all the pipelieruns which are older than 5mins but also want to keep maximum 10 pipelineruns

UI Example

tkn pr delete --keep=10 --keep-since=5
@pradeepitm12 pradeepitm12 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 23, 2021
@piyush-garg piyush-garg added this to the 0.22.0 milestone Nov 24, 2021
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2022
@piyush-garg piyush-garg modified the milestones: 0.22.0, 0.23.0 Mar 9, 2022
@piyush-garg
Copy link
Contributor

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2022
@divyansh42
Copy link
Member

/assign

@divyansh42 divyansh42 mentioned this issue Mar 15, 2022
Merged
4 tasks
@avinal avinal mentioned this issue Aug 10, 2022
Closed
avinal added a commit to avinal/operator that referenced this issue Aug 29, 2022
@avinal
Define keep and keep-since simultaneously
9213dce 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
@avinal avinal mentioned this issue Aug 29, 2022
Merged
4 tasks
avinal added a commit to avinal/operator that referenced this issue Aug 30, 2022
@avinal
Define keep and keep-since simultaneously
da5694c 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this issue Sep 2, 2022
@avinal
Define keep and keep-since simultaneously
3bb7ca5 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this issue Oct 17, 2022
@avinal
Define keep and keep-since simultaneously
f24cd60 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this issue Dec 26, 2022
@avinal
Define keep and keep-since simultaneously
6760e4a 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
avinal added a commit to avinal/operator that referenced this issue Dec 27, 2022
@avinal
Define keep and keep-since simultaneously
fa22307 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
tekton-robot pushed a commit to tektoncd/operator that referenced this issue Dec 29, 2022
@avinal @tekton-robot
Define keep and keep-since simultaneously
712ba2d 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes #974, tektoncd/website#419

Signed-off-by: Avinal Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyansh42 divyansh42

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

Support --keep and --keep-since together in tr/pr delete divyansh42/cli
4 participants
@piyush-garg @divyansh42 @pradeepitm12 @tekton-robot