Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Knative/K8s dependencies #1198

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Bump Knative/K8s dependencies #1198

merged 1 commit into from
Oct 7, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Oct 3, 2020

Changes

This incorporates the breaking changes from K8s 1.18 client libs through cli.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

/hold

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. labels Oct 3, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Oct 3, 2020

This depends on:

@mattmoor
Copy link
Member Author

mattmoor commented Oct 4, 2020

At least the unit test failures here should be fixed by: tektoncd/pipeline#3328

@mattmoor mattmoor force-pushed the bump-18 branch 3 times, most recently from 301fdb0 to 1d94231 Compare October 6, 2020 21:17
@mattmoor
Copy link
Member Author

mattmoor commented Oct 6, 2020

I am hoping that tektoncd/pipeline#3348 fixes the manifestation of the new structured-merge-diff problems here 🤞

@mattmoor
Copy link
Member Author

mattmoor commented Oct 6, 2020

Alright, it does...

@mattmoor mattmoor mentioned this pull request Oct 6, 2020
Merged
4 tasks
vdemeester
vdemeester approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @danielhelfand @piyush-garg @pradeepitm12 @chmouel

@vdemeester
Copy link
Member

/hold cancel

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 7, 2020
piyush-garg
piyush-garg reviewed Oct 7, 2020
View reviewed changes
go.mod Outdated
github.com/hako/durafmt v0.0.0-20191009132224-3f39dc1ed9f4
github.com/hinshun/vt10x v0.0.0-20180809195222-d55458df857c
github.com/jonboulle/clockwork v0.1.1-0.20190114141812-62fb9bc030d1
github.com/ktr0731/go-fuzzyfinder v0.2.0
github.com/pkg/errors v0.9.1
github.com/spf13/cobra v1.0.0
github.com/spf13/pflag v1.0.5
github.com/tektoncd/pipeline v0.16.3
github.com/tektoncd/pipeline v0.17.1-0.20201006183654-1710b688c023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it fine to bump to a commit in master branch, we may need first to bump to 0.17 branch and then do the release based on 0.17.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, we don't necessary need to do a release for each pipeline release. but, to be discussed

piyush-garg
piyush-garg reviewed Oct 7, 2020
View reviewed changes
go.mod Outdated
@@ -42,10 +42,16 @@ replace (
github.com/spf13/cobra => github.com/chmouel/cobra v0.0.0-20200107083527-379e7a80af0c
)

// Pin k8s deps to 0.17.6
// TODO(mattmoor): DO NOT SUBMIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP /hold

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we have a Github action that will flag DO NOT SUBMIT lines and add a failing check to the PR.

Happy to send y'all a PR with that if you have any interest? @vdemeester @imjasonh @bobcatfish @afrittoli

@piyush-garg
Copy link
Contributor

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Oct 7, 2020

/hold

We need to merge the upstream PRs, this is working off my fork!

@mattmoor
Copy link
Member Author

mattmoor commented Oct 7, 2020

/hold cancel

Alright, I believe all of the dependent PRs have landed and this is RFAL.

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Oct 7, 2020

/assign @danielhelfand @chmouel @vdemeester

danielhelfand
danielhelfand approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let one more set of eyes take a look, but looks good to me.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

mattmoor commented Oct 7, 2020

@danielhelfand fwiw, @vdemeester had a look above before my upstream PRs landed (and I dealt with merge conflicts).

@mattmoor
Copy link
Member Author

mattmoor commented Oct 7, 2020

cc @n3wscott reviewed a lot of the Knative 0.18 migration PRs

@n3wscott
Copy link

n3wscott commented Oct 7, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@tekton-robot tekton-robot merged commit 8b6afc4 into tektoncd:master Oct 7, 2020
@mattmoor mattmoor deleted the bump-18 branch October 7, 2020 23:48
piyush-garg added a commit that referenced this pull request Oct 21, 2020
@piyush-garg
New version v0.13.1
b2ac898 
#1194 | [Daniel Helfand] update README to v0.13.0 | 2020/09/30-22:18
#1196 | [Chmouel Boudjnah] Update OSX instruction to install from brew 🍻 | 2020/10/02-11:36
#1197 | [Daniel Helfand] reorganize release process docs and add details | 2020/10/07-07:26
#1192 | [Daniel Helfand] add eventlistener logs command | 2020/10/07-08:00
#1198 | [Matt Moore] Bump Knative/K8s dependencies | 2020/10/08-00:34
#1201 | [Daniel Helfand] avoid use of previous TaskRunSpecStatus and PipelineRunSpecStatus | 2020/10/13-17:32
#1205 | [Daniel Helfand] remove assertions to help with debugging eventlistener e2e failures | 2020/10/20-07:27
#1207 | [Piyush Garg] tkn pr describe failing in pr with conditions | 2020/10/20-08:57
#1189 | [Daniel Helfand] refactor pipelinerun and taskrun cancel err based on condition status | 2020/10/20-09:15
#1189 | [Daniel Helfand] add pipelinerun and taskrun cancel e2e tests | 2020/10/20-09:15
null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: EventListener | 2020/10/21-07:21
null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerBinding | 2020/10/21-08:00

Signed-off-by: Piyush Garg <[email protected]>
@pradeepitm12 pradeepitm12 mentioned this pull request Oct 28, 2020
Merged
4 tasks
pradeepitm12 added a commit to pradeepitm12/cli that referenced this pull request Nov 4, 2020
@pradeepitm12
Bump pipeline and triggers deps
269b9bb 
This bumps triggers to 0.9.1
For pipeline its already taken care in
[tektoncd#1198](tektoncd#1198)

Note: takes care of deprecations will need to
clean after deprecations are not support

Signed-off-by: Pradeep Kumar <[email protected]>
tekton-robot pushed a commit that referenced this pull request Nov 4, 2020
@pradeepitm12 @tekton-robot
Bump pipeline and triggers deps
9dd63cd 
This bumps triggers to 0.9.1
For pipeline its already taken care in
[#1198](#1198)

Note: takes care of deprecations will need to
clean after deprecations are not support

Signed-off-by: Pradeep Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand danielhelfand approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@vdemeester vdemeester

@chmouel chmouel

@n3wscott n3wscott

@danielhelfand danielhelfand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mattmoor @vdemeester @piyush-garg @tekton-robot @n3wscott @danielhelfand @chmouel