Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSX instruction to install from brew 🍻 #1196

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 2, 2020

Changes

Update OSX instructions to point to the official brew repo.

We still keep the upload to tektoncd/tools since it's easy to maintain (it's part of goreleaser)
and if there is an issue merging brew update we can still point user at it in the future.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

Packages are available from the official [brew](https://brew.sh) repository. You still can install tektoncd cli on OSX from the `tektoncd/tools` tap since both would be supported for the foreseeable future. 

Update OSX instructions to point to the official brew repo.

We still keep the upload to tektoncd/tools since it's easy to maintain (it's part of goreleaser) 
and if there is an issue merging brew update we can still point user at it in the future.
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 2, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@tekton-robot tekton-robot merged commit 763657b into master Oct 2, 2020
@chmouel chmouel deleted the chmouel-update-osx-instructions branch October 2, 2020 15:13
piyush-garg added a commit that referenced this pull request Oct 21, 2020
#1194 | [Daniel Helfand] update README to v0.13.0 | 2020/09/30-22:18
#1196 | [Chmouel Boudjnah] Update OSX instruction to install from brew 🍻 | 2020/10/02-11:36
#1197 | [Daniel Helfand] reorganize release process docs and add details | 2020/10/07-07:26
#1192 | [Daniel Helfand] add eventlistener logs command | 2020/10/07-08:00
#1198 | [Matt Moore] Bump Knative/K8s dependencies | 2020/10/08-00:34
#1201 | [Daniel Helfand] avoid use of previous TaskRunSpecStatus and PipelineRunSpecStatus | 2020/10/13-17:32
#1205 | [Daniel Helfand] remove assertions to help with debugging eventlistener e2e failures | 2020/10/20-07:27
#1207 | [Piyush Garg] tkn pr describe failing in pr with conditions | 2020/10/20-08:57
#1189 | [Daniel Helfand] refactor pipelinerun and taskrun cancel err based on condition status | 2020/10/20-09:15
#1189 | [Daniel Helfand] add pipelinerun and taskrun cancel e2e tests | 2020/10/20-09:15
null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: EventListener | 2020/10/21-07:21
null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerBinding | 2020/10/21-08:00

Signed-off-by: Piyush Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants