Sets Gradle home and fixes minor doc issues #400
Conversation
- Set Gradle user home with --gradle-user-home - Fixes docs (tekton.dev/v1alpha1 --> tekton.dev/v1beta1)
|
|
tekton-robot
added
the
size/S
|
/assign @loosebazooka |
| @@ -42,6 +42,7 @@ spec: | |||
| --stacktrace --console=plain \ | |||
| --init-script=/tekton/home/init-script.gradle \ | |||
| -Duser.home=/tekton/home \ | |||
| --gradle-user-home=/tekton/home/.gradle \ | |||
There was a problem hiding this comment.
do we need both these values? line 45 and 46?
There was a problem hiding this comment.
Maybe not, but just wanted to be on the safe side. BTW, --gradle-user-home is documented in man gradle, so I think this is the right way to do it. Do you think we should remove line 64?
There was a problem hiding this comment.
I have no idea, I guess it couldn't hurt.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loosebazooka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
tekton-robot
added
the
needs-rebase
|
@chanseokoh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing as the changes are part of the merged #407. |
Changes
--gradle-user-home.tekton.dev/v1alpha1-->tekton.dev/v1beta1)Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.