Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets Gradle home and fixes minor doc issues #400

Closed
wants to merge 1 commit into from
Closed

Sets Gradle home and fixes minor doc issues #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jib-gradle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/master/jib-g
This TaskRun runs the Task to fetch a Git repo, and build and push a container
image using Jib (Gradle)

```
apiVersion: tekton.dev/v1alpha1
```yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineResource
metadata:
name: example-image
Expand All @@ -44,7 +44,7 @@ spec:
value: gcr.io/tekton-task-project/my-image
```

```
```yaml
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
Expand Down
1 change: 1 addition & 0 deletions jib-gradle/jib-gradle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ spec:
--stacktrace --console=plain \
--init-script=/tekton/home/init-script.gradle \
-Duser.home=/tekton/home \
--gradle-user-home=/tekton/home/.gradle \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both these values? line 45 and 46?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not, but just wanted to be on the safe side. BTW, --gradle-user-home is documented in man gradle, so I think this is the right way to do it. Do you think we should remove line 64?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, I guess it couldn't hurt.

-Dgradle.user.home=/tekton/home/.gradle \
-Djib.allowInsecureRegistries=$(params.INSECUREREGISTRY) \
-Djib.to.image=$(resources.outputs.image.url)
Expand Down
6 changes: 3 additions & 3 deletions jib-maven/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ kubectl apply -f https://raw.githubusercontent.com/tektoncd/catalog/master/jib-m
This TaskRun runs the Task to fetch a Git repo, and build and push a container
image using Jib (Maven)

```
apiVersion: tekton.dev/v1alpha1
```yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineResource
metadata:
name: example-image
Expand All @@ -44,7 +44,7 @@ spec:
value: gcr.io/tekton-task-project/my-image
```

```
```yaml
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
Expand Down