Fix for Issue 1285-: SendMail task was failing to execute successfully #1286

sudhishmk · 2024-06-30T16:53:05Z

Changes to fix sendmail task issue -: SendMail task was failing to execute successfully

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (for new tasks or changed functionality)
- See the end-to-end testing documentation for guidance and CI details.
Meets the Tekton contributor standards (including functionality, content, code)
Commit messages follow commit message best practices
Has a kind label. You can add one by adding a comment on this PR that
contains /kind <type>. Valid types are bug, cleanup, design, documentation,
feature, flake, misc, question, tep
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide for more details.

linux-foundation-easycla · 2024-06-30T16:53:10Z

The committers listed above are authorized under a signed CLA.

✅ login: sudhishmk / name: Sudhish Nair (ab8f5fa)

tekton-robot · 2024-06-30T16:53:49Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..9f56ca9 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..1327dfe 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

tekton-robot · 2024-06-30T16:54:03Z

Catlin Output

FILE: task/sendmail/0.2/sendmail.yaml
ERROR: Resource path is invalid; expected path: task/sendmail/0.1/sendmail.yaml

sudhishmk · 2024-07-01T10:58:16Z

/assign @akihikokuroda

task/sendmail/0.2/sendmail.yaml

tekton-robot · 2024-07-03T15:10:40Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..9f56ca9 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..31f2536 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -3,7 +3,7 @@ kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
     tekton.dev/pipelines.minVersion: "0.12.1"
     tekton.dev/categories: Messaging
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

khrm

Can you squash the commits to one and change the subject in PR and commit?

khrm · 2024-07-04T12:07:50Z

You have to change the email in git using: git config --global user.email or add the newer email to Github profile as secondary/primary for easy-cla

tekton-robot · 2024-07-04T15:05:37Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..9f56ca9 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..31f2536 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -3,7 +3,7 @@ kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
     tekton.dev/pipelines.minVersion: "0.12.1"
     tekton.dev/categories: Messaging
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

vinamra28 · 2024-07-15T10:50:44Z

@sudhishmk, can you please fix the CLA?

sudhishmk · 2024-07-15T16:04:05Z

/easycla

sudhishmk · 2024-07-15T16:18:14Z

@sudhishmk, can you please fix the CLA?

@vinamra28 Done

tekton-robot · 2024-07-16T14:02:17Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..9f56ca9 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..31f2536 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -3,7 +3,7 @@ kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
     tekton.dev/pipelines.minVersion: "0.12.1"
     tekton.dev/categories: Messaging
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

vinamra28

hi @sudhishmk, apologies for seeing this late. Can you please take a look at following reviews. Can probably merge after this

task/sendmail/0.2/sendmail.yaml

tekton-robot · 2024-08-20T08:22:18Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..1762993 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
@@ -60,7 +60,7 @@ The Task can be run on `linux/amd64`, `linux/s390x`, `linux/arm64` and `linux/pp
 This TaskRun runs the Task to send an email to the receivers via the SMTP server.
 
 ```
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: TaskRun
 metadata:
   name: mail-taskrun
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..5e8c460 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -1,9 +1,9 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
     tekton.dev/pipelines.minVersion: "0.12.1"
     tekton.dev/categories: Messaging
@@ -32,7 +32,7 @@ spec:
     description: recipient email addresses (space delimited list)
   steps:
   - name: send
-    image: docker.io/library/python:3.8-alpine@sha256:e11bbd37d4371894e954421b85dbe8dd4eb7198d7cb4ed144ab529f19f57c3f1 #tag: 3.8-alpine
+    image: docker.io/library/python:3.12-alpine@sha256:c2f41e6a5a67bc39b95be3988dd19fbd05d1b82375c46d9826c592cca014d4de #tag: 3.12-alpine
     script: |
       #!/usr/bin/env python3
       import smtplib, ssl, os
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

vinamra28 · 2024-08-20T08:57:48Z

also can you please squash the commits once all the comments are addressed?

tekton-robot · 2024-08-20T09:26:31Z

Catlin Output

FILE: task/conftest/0.2/conftest.yaml

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In skopeo-copy-skopeo-copy line 15:
    read -ra sourceDest <<<"${cmd}"
         ^-^ SC3045 (warning): In POSIX sh, read -a is undefined.
                        ^-^ SC3011 (warning): In POSIX sh, here-strings are undefined.


In skopeo-copy-skopeo-copy line 16:
    skopeo copy --multi-arch="$(params.multiArch)" "${sourceDest[@]}" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
                                                    ^--------------^ SC3054 (warning): In POSIX sh, array references are undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3011 -- In POSIX sh, here-strings are und...
  https://www.shellcheck.net/wiki/SC3045 -- In POSIX sh, read -a is undefined.
  https://www.shellcheck.net/wiki/SC3054 -- In POSIX sh, array references are...

ERROR: /bin/sh, [-n] failed:
skopeo-copy-skopeo-copy: line 15: syntax error: unexpected redirection

tekton-robot · 2024-08-20T09:26:38Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..1762993 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
@@ -60,7 +60,7 @@ The Task can be run on `linux/amd64`, `linux/s390x`, `linux/arm64` and `linux/pp
 This TaskRun runs the Task to send an email to the receivers via the SMTP server.
 
 ```
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: TaskRun
 metadata:
   name: mail-taskrun
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..9c59010 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -1,11 +1,11 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
-    tekton.dev/pipelines.minVersion: "0.12.1"
+    tekton.dev/pipelines.minVersion: "0.50.0"
     tekton.dev/categories: Messaging
     tekton.dev/tags: mail
     tekton.dev/displayName: "send mail"
@@ -32,7 +32,7 @@ spec:
     description: recipient email addresses (space delimited list)
   steps:
   - name: send
-    image: docker.io/library/python:3.8-alpine@sha256:e11bbd37d4371894e954421b85dbe8dd4eb7198d7cb4ed144ab529f19f57c3f1 #tag: 3.8-alpine
+    image: docker.io/library/python:3.12-alpine@sha256:c2f41e6a5a67bc39b95be3988dd19fbd05d1b82375c46d9826c592cca014d4de #tag: 3.12-alpine
     script: |
       #!/usr/bin/env python3
       import smtplib, ssl, os
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

Fix for issue-1285 Send mail task was failing to complete

tekton-robot · 2024-08-20T09:34:18Z

Diff between version 0.1 and 0.2

diff --git a/task/sendmail/0.1/README.md b/task/sendmail/0.2/README.md
index aafe880..1762993 100644
--- a/task/sendmail/0.1/README.md
+++ b/task/sendmail/0.2/README.md
@@ -5,7 +5,7 @@ This task sends a simple email to receivers via SMTP server
 ## Install the Task and create a secret
 
 ```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.1/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/sendmail/0.2/raw
 ```
 
 Create a secret that has the SMTP server information
@@ -60,7 +60,7 @@ The Task can be run on `linux/amd64`, `linux/s390x`, `linux/arm64` and `linux/pp
 This TaskRun runs the Task to send an email to the receivers via the SMTP server.
 
 ```
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: TaskRun
 metadata:
   name: mail-taskrun
diff --git a/task/sendmail/0.1/sendmail.yaml b/task/sendmail/0.2/sendmail.yaml
index b512852..9c59010 100644
--- a/task/sendmail/0.1/sendmail.yaml
+++ b/task/sendmail/0.2/sendmail.yaml
@@ -1,11 +1,11 @@
-apiVersion: tekton.dev/v1beta1
+apiVersion: tekton.dev/v1
 kind: Task
 metadata:
   name: sendmail
   labels:
-    app.kubernetes.io/version: "0.1"
+    app.kubernetes.io/version: "0.2"
   annotations:
-    tekton.dev/pipelines.minVersion: "0.12.1"
+    tekton.dev/pipelines.minVersion: "0.50.0"
     tekton.dev/categories: Messaging
     tekton.dev/tags: mail
     tekton.dev/displayName: "send mail"
@@ -32,7 +32,7 @@ spec:
     description: recipient email addresses (space delimited list)
   steps:
   - name: send
-    image: docker.io/library/python:3.8-alpine@sha256:e11bbd37d4371894e954421b85dbe8dd4eb7198d7cb4ed144ab529f19f57c3f1 #tag: 3.8-alpine
+    image: docker.io/library/python:3.12-alpine@sha256:c2f41e6a5a67bc39b95be3988dd19fbd05d1b82375c46d9826c592cca014d4de #tag: 3.12-alpine
     script: |
       #!/usr/bin/env python3
       import smtplib, ssl, os
@@ -53,8 +53,11 @@ spec:
       if tls == 'True':
           context = ssl.create_default_context()
           server = smtplib.SMTP_SSL(smtp_server, port, context=context)
+          server.ehlo()
       else:
           server = smtplib.SMTP(smtp_server, port)
+          server.ehlo()
+          server.starttls()
       if password != '':
           server.login(user, password)
       for receiver in [item for item in receiver_emails.split(' ') if item]:

sudhishmk · 2024-08-20T09:34:27Z

also can you please squash the commits once all the comments are addressed?

Done

vinamra28

/lgtm

tekton-robot · 2024-08-20T13:38:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~task/sendmail/OWNERS~~ [vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from akihikokuroda and vdemeester June 30, 2024 16:53

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 30, 2024

sudhishmk mentioned this pull request Jun 30, 2024

Sendmail task is failing #1285

Closed

tekton-robot assigned akihikokuroda Jul 1, 2024

vdemeester reviewed Jul 3, 2024

View reviewed changes

task/sendmail/0.2/sendmail.yaml Outdated Show resolved Hide resolved

sudhishmk requested a review from vdemeester July 4, 2024 11:47

khrm reviewed Jul 4, 2024

View reviewed changes

sudhishmk force-pushed the issue-1285 branch from 00b3dab to 73f0bb1 Compare July 4, 2024 15:04

sudhishmk changed the title ~~FIx for Issue 1285~~ Fix for Issue 1285-: SendMail task was failing to execute successfully Jul 4, 2024

sudhishmk closed this Jul 16, 2024

sudhishmk reopened this Jul 16, 2024

vinamra28 reviewed Aug 20, 2024

View reviewed changes

task/sendmail/0.2/sendmail.yaml Outdated Show resolved Hide resolved

task/sendmail/0.2/sendmail.yaml Outdated Show resolved Hide resolved

task/sendmail/0.2/sendmail.yaml Outdated Show resolved Hide resolved

.

ab8f5fa

Fix for issue-1285 Send mail task was failing to complete

sudhishmk force-pushed the issue-1285 branch from 695ed90 to ab8f5fa Compare August 20, 2024 09:33

vinamra28 approved these changes Aug 20, 2024

View reviewed changes

tekton-robot assigned vinamra28 Aug 20, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024

tekton-robot merged commit a8c2c4d into tektoncd:main Aug 20, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for Issue 1285-: SendMail task was failing to execute successfully #1286

Fix for Issue 1285-: SendMail task was failing to execute successfully #1286

sudhishmk commented Jun 30, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jun 30, 2024 •

edited

Loading

tekton-robot commented Jun 30, 2024

tekton-robot commented Jun 30, 2024

sudhishmk commented Jul 1, 2024

tekton-robot commented Jul 3, 2024

khrm left a comment

khrm commented Jul 4, 2024 •

edited

Loading

tekton-robot commented Jul 4, 2024

vinamra28 commented Jul 15, 2024

sudhishmk commented Jul 15, 2024

sudhishmk commented Jul 15, 2024 •

edited

Loading

tekton-robot commented Jul 16, 2024

vinamra28 left a comment

tekton-robot commented Aug 20, 2024

vinamra28 commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

sudhishmk commented Aug 20, 2024

vinamra28 left a comment

tekton-robot commented Aug 20, 2024

Fix for Issue 1285-: SendMail task was failing to execute successfully #1286

Fix for Issue 1285-: SendMail task was failing to execute successfully #1286

Conversation

sudhishmk commented Jun 30, 2024 • edited Loading

Changes to fix sendmail task issue -: SendMail task was failing to execute successfully

Submitter Checklist

linux-foundation-easycla bot commented Jun 30, 2024 • edited Loading

tekton-robot commented Jun 30, 2024

tekton-robot commented Jun 30, 2024

sudhishmk commented Jul 1, 2024

tekton-robot commented Jul 3, 2024

khrm left a comment

Choose a reason for hiding this comment

khrm commented Jul 4, 2024 • edited Loading

tekton-robot commented Jul 4, 2024

vinamra28 commented Jul 15, 2024

sudhishmk commented Jul 15, 2024

sudhishmk commented Jul 15, 2024 • edited Loading

tekton-robot commented Jul 16, 2024

vinamra28 left a comment

Choose a reason for hiding this comment

tekton-robot commented Aug 20, 2024

vinamra28 commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

tekton-robot commented Aug 20, 2024

sudhishmk commented Aug 20, 2024

vinamra28 left a comment

Choose a reason for hiding this comment

tekton-robot commented Aug 20, 2024

sudhishmk commented Jun 30, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jun 30, 2024 •

edited

Loading

khrm commented Jul 4, 2024 •

edited

Loading

sudhishmk commented Jul 15, 2024 •

edited

Loading