Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming of entire workbench #8

Merged
merged 4 commits into from
May 18, 2017
Merged

Theming of entire workbench #8

merged 4 commits into from
May 18, 2017

Conversation

pahen
Copy link
Collaborator

@pahen pahen commented May 17, 2017

This PR adds the script npm run build to automatically generate the 3 themes from the colors schemes defined in https://github.com/ayu-theme/ayu-colors.

This is tested with the latest Code Insiders. It should work with 1.12 too but with some elements not styled correctly.

I removed the italic styling on comments in the editor since there's currently no way to disable that in vscode and fonts are really hard to read in italic (like Operator Mono).

I also renamed the name of the package from "ayu" to "vscode-ayu" since I couldn't install "ayu" from NPM due to conflicting name in package.json.

There's still things I feel missing in the theme but there's currently no support for styling everything in the theming API yet. But I'll suggest we'll wait with that and create a roadmap and add that when/if the support is added. Here's some of the things I would like to fix:

Install the VSIX here: https://www.dropbox.com/s/eyg6l692fd73fju/vscode-ayu-0.3.0.vsix?dl=1

Fixes #7
Fixes #3

Light
screen shot 2017-05-18 at 11 28 52

Dark
screen shot 2017-05-18 at 11 29 09

Mirage
screen shot 2017-05-18 at 11 29 25

@pahen pahen changed the title Workbench Theming of Workbench May 17, 2017
@pahen pahen changed the title Theming of Workbench Theming of entire workbench May 17, 2017
@teabyii
Copy link
Collaborator

teabyii commented May 17, 2017

Nice, I will check it later.

@pahen pahen mentioned this pull request May 17, 2017
@pahen
Copy link
Collaborator Author

pahen commented May 18, 2017

I updated terminal colors to use same colors as https://github.com/ayu-theme/ayu-vim/tree/master/term. It uses better colors for the light theme.

@teabyii teabyii merged commit e7c4f77 into ayu-theme:master May 18, 2017
@teabyii
Copy link
Collaborator

teabyii commented May 18, 2017

@pahen I reverted the package name to "ayu" because I could not update the extention name in vscode market. I didn't want to publish a new one, so. And we can install package ayu by npm install when ayu in devDependencies. It's just like a trick.😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt workbench themes VSCode ayu light selection + find highlight = bad contrast
2 participants