-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themeing for editor squiggles background #16204
Comments
Please. |
Green squiggles used for warning messages are hardly visible with dark color themes. |
I posted a workaround (hack) on the stackoverflow question opened by the OP - it works (UPDATE - no longer seems to work as of v1.10 release), but I am having to reapply this on every update, and it makes VS Code report itself as corrupted, both of which are pretty inconvenient. It would be great to just have this configuration 'natively' instead. This is a significant accessibility hurdle for colorblind people using VS code. I think any solution to making this configurable should be as low-friction as possible. For example, please consider just allowing raw css to be specified for the error style, on top of an existing theme, similarly to how this workaround does. If these styles are deeply integrated into the theming and a completely new theme has to be created to change them, this may make it more of a hassle than necessary to tweak the styles, and the themes will not necessarily even be very shareable since different people will want/need slightly different tweaks. Thanks for all the great work! |
I'd love to have the ability to highlight a whole line when there's an error. It's so easy to miss an error when scanning through a file. |
Yes, please add this. |
Agree with davnicwil "This is a significant accessibility hurdle for colorblind people using VS code." |
Colorblind person here. PLEASE make this change. The current color is near impossible to see for some of us. |
Closing as duplicate of #9819 |
I'd like to be able to put a red background behind the Line Number on the left as well. It's easy to miss an error that is one character long, but if the line number takes a red background, that's impossible to miss. |
agree with @thomstark and Please |
I absolutely skip errors all the time, even when I know it's somewhere on the page - just cannot find it. |
Please? So hard to see a squiggle under a semicolon at the end of a line. One thing I really miss about Sublime and some of its linter plugins. |
I usually have to use the marker on the scroll bar on the right (red line) to actually find it; it blends in too much. MS - just make this configurable, like: {
"editer.lintConfig": {
"lintStyle": "x" // An alternate style for the squiggle, maybe "squiggle, X's, asterisk, question marks
"width": 15, // line width
"height": 10, // height of the error design from point to point
"foreground": "#f50000",
"background": "rgba(255,105,180, 0.5)"
}
} It would be nice if we had some real hooks to write extensions for this. This is actually something I'd rather be able to target with an extension vs. just theming. It would be an extension worth the time of creating 🥇 |
You guys have got to checkout this VS Code extension. This is better than I could have imagined to solve this issue: https://marketplace.visualstudio.com/items?itemName=PhilHindle.errorlens It's beautiful. Here's an example on a TypeScript Express server I where I have a ton of flags from TS: |
@misolori awesome work, thanks for this change! |
I would like to have custom highlight for errors:
![rxzsp](https://cloud.githubusercontent.com/assets/1526680/20702181/169fa9cc-b617-11e6-9ada-954bb2a9c49f.png)
for example such an aggressive one:
![yahve](https://cloud.githubusercontent.com/assets/1526680/20702202/28c9035a-b617-11e6-8003-abc735ae4f7b.png)
Started discussion on stackoverflow and found that for now VSCode does not have such option.
The text was updated successfully, but these errors were encountered: