Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themeing for editor squiggles background #16204

Closed
stevermeister opened this issue Nov 29, 2016 · 17 comments · Fixed by #110112
Closed

Themeing for editor squiggles background #16204

stevermeister opened this issue Nov 29, 2016 · 17 comments · Fixed by #110112
Assignees
Labels
editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@stevermeister
Copy link

I would like to have custom highlight for errors:
rxzsp

for example such an aggressive one:
yahve

Started discussion on stackoverflow and found that for now VSCode does not have such option.

@chrmarti chrmarti added the themes Color theme issues label Nov 29, 2016
@chrmarti chrmarti added the feature-request Request for new features or functionality label Nov 29, 2016
@alexdima alexdima changed the title an option to change styles for error output for Style Theme Themeing for editor squiggles Nov 30, 2016
@alexdima alexdima added editor editor-core Editor basic functionality labels Nov 30, 2016
@alexdima alexdima added this to the Backlog milestone Nov 30, 2016
@alexdima alexdima removed their assignment Nov 30, 2016
@smuuf
Copy link

smuuf commented Dec 22, 2016

Please.

@pierredewilde
Copy link

Green squiggles used for warning messages are hardly visible with dark color themes.

@davnicwil
Copy link
Contributor

davnicwil commented Feb 6, 2017

I posted a workaround (hack) on the stackoverflow question opened by the OP - it works (UPDATE - no longer seems to work as of v1.10 release), but I am having to reapply this on every update, and it makes VS Code report itself as corrupted, both of which are pretty inconvenient. It would be great to just have this configuration 'natively' instead.

This is a significant accessibility hurdle for colorblind people using VS code.

I think any solution to making this configurable should be as low-friction as possible. For example, please consider just allowing raw css to be specified for the error style, on top of an existing theme, similarly to how this workaround does. If these styles are deeply integrated into the theming and a completely new theme has to be created to change them, this may make it more of a hassle than necessary to tweak the styles, and the themes will not necessarily even be very shareable since different people will want/need slightly different tweaks.

Thanks for all the great work!

@nixterrimus
Copy link

I'd love to have the ability to highlight a whole line when there's an error. It's so easy to miss an error when scanning through a file.

@johnengleman
Copy link

Yes, please add this.

@gbritting
Copy link

Agree with davnicwil "This is a significant accessibility hurdle for colorblind people using VS code."

@lanegoolsby
Copy link

lanegoolsby commented Apr 23, 2017

Colorblind person here. PLEASE make this change. The current color is near impossible to see for some of us.

@bpasero
Copy link
Member

bpasero commented May 21, 2017

Closing as duplicate of #9819

@bpasero bpasero closed this as completed May 21, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 21, 2017
@davnicwil
Copy link
Contributor

@bpasero this issue isn't really a duplicate of #9819, in my opinion. Changing the color of the squiggles is an improvement, and a welcome change in v1.12, but I also want to add a background highlight to the error. Will there be more properties coming which allow for this?

@bpasero bpasero reopened this Jul 12, 2017
@bpasero bpasero removed the *duplicate Issue identified as a duplicate of another issue(s) label Jul 12, 2017
@bpasero bpasero changed the title Themeing for editor squiggles Themeing for editor squiggles background Jul 12, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@thomstark
Copy link

I'd like to be able to put a red background behind the Line Number on the left as well. It's easy to miss an error that is one character long, but if the line number takes a red background, that's impossible to miss.

@lostncg
Copy link

lostncg commented Apr 28, 2018

agree with @thomstark and Please

@tomholub
Copy link

I absolutely skip errors all the time, even when I know it's somewhere on the page - just cannot find it.

@stevage
Copy link

stevage commented Jan 30, 2019

Please?

So hard to see a squiggle under a semicolon at the end of a line. One thing I really miss about Sublime and some of its linter plugins.

@methodbox
Copy link

I absolutely skip errors all the time, even when I know it's somewhere on the page - just cannot find it.

I usually have to use the marker on the scroll bar on the right (red line) to actually find it; it blends in too much.

MS - just make this configurable, like:

{
    "editer.lintConfig": {
        "lintStyle": "x"  //  An alternate style for the squiggle, maybe "squiggle, X's, asterisk, question marks
        "width":  15, //  line width
        "height": 10, //  height of the error design from point to point
        "foreground": "#f50000",
        "background": "rgba(255,105,180, 0.5)"
    }
}

It would be nice if we had some real hooks to write extensions for this. This is actually something I'd rather be able to target with an extension vs. just theming. It would be an extension worth the time of creating 🥇

@methodbox
Copy link

methodbox commented May 19, 2019

You guys have got to checkout this VS Code extension. This is better than I could have imagined to solve this issue:

https://marketplace.visualstudio.com/items?itemName=PhilHindle.errorlens

It's beautiful. Here's an example on a TypeScript Express server I where I have a ton of flags from TS:

Screen-Shot-2019-05-19-at-11-24-07-AM

@alexdima alexdima added editor-rendering Editor rendering issues editor-theming Issues related to the way themes are applied to editors and removed editor-core Editor basic functionality editor-rendering Editor rendering issues labels Oct 21, 2019
@miguelsolorio miguelsolorio modified the milestones: Backlog, November 2020 Nov 9, 2020
@miguelsolorio
Copy link
Contributor

You can now use the following color tokens to highlight the background color of errors/warnings/info in the editor:

  • editorInfo.background
  • editorWarning.background
  • editorError.background

image

@davnicwil
Copy link
Contributor

@misolori awesome work, thanks for this change!

@miguelsolorio miguelsolorio added the verification-needed Verification of issue is requested label Nov 30, 2020
@bpasero bpasero added verified Verification succeeded and removed verified Verification succeeded labels Dec 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-theming Issues related to the way themes are applied to editors feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.