Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt workbench themes #7

Closed
joaomoreno opened this issue Apr 12, 2017 · 11 comments · Fixed by #8
Closed

Adopt workbench themes #7

joaomoreno opened this issue Apr 12, 2017 · 11 comments · Fixed by #8

Comments

@joaomoreno
Copy link

Hey, VS Code dev here. I love these themes!

VS Code Workbench theming is now in preview, but we can already start using it. I would love to get these themes working across the whole workbench.

Let me know if you'll accept a PR.

@pahen
Copy link
Collaborator

pahen commented May 4, 2017

I've started adding custom theme colors for the entire workbench for the Ayu Dark theme. Let me know if you're interested in a PR! Note that it's a work in progress.

screen shot 2017-05-04 at 09 59 18

@joaomoreno
Copy link
Author

Looks great, although the lack of contrast between the background of the different parts is kind of strange.

@pahen
Copy link
Collaborator

pahen commented May 4, 2017

Yes, I agree. But the goal is to have it as close as the original Sublime Text theme as possible. But there's still elements that can't be themed to achieve that now. Mostly lack of border theming. And the issue microsoft/vscode#25774 created by me.

@Michael-ABOSS
Copy link

Awesome! was checking if this would be added. Good to see you are already working on it!

@teabyii
Copy link
Collaborator

teabyii commented May 8, 2017

Nice, you are welcome. @pahen

@pahen
Copy link
Collaborator

pahen commented May 8, 2017

Here's a gist if someone want to test it: https://gist.github.com/pahen/d435d91d21c7b3556c156e5618b7dd3d

Just put it in your settings. I'll create a PR once the theming API in vscode is satisfying enough :)

@pahen
Copy link
Collaborator

pahen commented May 10, 2017

I'm making progress on all 3 versions (light, mirage, and dark). Screenshots coming soon! :)

@Michael-ABOSS
Copy link

I have been using the Dark theme you posted in the gist for the last two days. Looking very good have not run in to any bugs. Will also test the other versions when you are ready

@pahen
Copy link
Collaborator

pahen commented May 11, 2017

The themes starting to get really useful now :) But there's still a couple of things to fix. Here's a VSIX package if you want to install it and test https://www.dropbox.com/s/eyg6l692fd73fju/vscode-ayu-0.3.0.vsix?dl=1. Uninstall the current Ayu theme first. And remember to remove any custom colors in workbench.colorCustomizations if you have them in your settings.

Light
screen shot 2017-05-11 at 07 56 51

Dark
screen shot 2017-05-11 at 07 56 35

Mirage
screen shot 2017-05-11 at 07 57 03

cc @joaomoreno @Michael-ABOSS @teabyii

@joaomoreno
Copy link
Author

Pretty cool. I'd love to get some contrast between the sidebar and the editor, even if only a slight dim border.

@pahen
Copy link
Collaborator

pahen commented May 17, 2017

Latest version can be tested here: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants