-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple visionOS build support #2549
Conversation
Thank you, @vincentneo! After your pull request #2517 has been merged the example already uses OpenSSL 3 for building, hence the first commit isn't needed anymore. Could you rebase the commits on the latest master instead of merging? |
The OS has been renamed to visionOS. Could you use this name for it instead of xrOS? |
I didn't mean that we need to rename Xcode flags. The comment was about local variables such as "XRSIMULATOR"/"XROS"/"xrOS". |
Ah got it; Btw, did the rebase work? I can't tell. |
Old commits are still there, therefore the branch as the whole cannot be rebased due to conflicts. Likely, you need to force push the new rebased branch instead of merging it with master. |
based on openssl-3.1.1 build script.
@levlam may I verify with you that the rebase is correct now? if so I will work on renaming |
Yes, it looks correct now. Also, why the applied patch was renamed from ../Python-Apple-support.patch to ../xros-support.patch in the first commit? |
Right, that will be changed. Also, I tried to change the XR references, and it seems if I were to change xros to visionos (while keeping the target name xros/xrsimulator) in the openssl patch file, it doesn't compile, probably need more time to understand why that is the case. |
Have renamed to visionOS, and it should still build fine |
Thank you, @vincentneo! |
This pull request aims to support building TDLib for the Apple xrOS/visionOS platform.
As it is essentially similar to modern Apple platforms, I reckon there be no other changes, except to update scripts to fit the platform.
Scripts are adapted to allow for building for the said platform right now but is yet to be tested, hence it is a draft PR.
Compiling requires Xcode 15 beta and CMake 3.27.
Do also note that this is based on #2517's OpenSSL script, and the CMake script also has legacy architectures removed for iOS right now.
UPDATE: Good news, built a quick sample project, and was able to see TDLib's verbose logs streaming into the console, when running on visionOS simulator, Xcode 15.0 beta 5 (15A5209g)!