-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iOS example to build OpenSSL 3.1.1 #2517
Conversation
OpenSSL 3.* is much slower and has significantly bigger binary size than previous OpenSSL versions. Any older version of OpenSSL is much better as a general purpose cryptographic library, and hence it is more preferable for TDLib. Unfortunately, OpenSSL 1.1.1 will reach EOL in less than 3 month, which forces switching to OpenSSL 3.*. Therefore, I will accept the pull request after testing anyway, but overall it will bring only downsides to the iOS build example. |
Yes, it looks to be about twice as large as before, though I hadn't realised (at least TDLib as a whole) being slower because of OpenSSL 3
Yeah that was why I personally used the 3.x release, more of a precaution for me to get things ready when the time comes. |
@vincentneo Please consider removing armv7 support from other parts of TDLib. cc @levlam My simple patch I'm using daily. |
@Kylmakalle If you mean all armv7 support, I don't think that is a good idea. With my pull request I remember that only That is because for projects targeting at minimum watchOS 8.x, |
@vincentneo Let me clarify: now with v3 |
@Kylmakalle thanks for clarifying. Agreed on your sentiment on armv7 and armv7s for iOS. |
Gave this PR a try on my CI. Builds just fine. OpenSSL is slightly smaller for iOS btw. |
@Kylmakalle Actually to think about it, probably tdlib won't build for iOS without patching away armv7 since this openssl build doesn't have it. openssl on iOS is smaller due to lack of armv7 and armv7s binaries by the way |
Thank you, @vincentneo! And thank you, @Kylmakalle for the valuable feedback. |
This pull request includes modified script and patch which I personally use to compile the latest OpenSSL for tdlib.
openssl-1.0.2n-darwin-arm64.patch
added in #1620, has also been removed as the script has been modified to use the currently newest commit of Python-Apple-support, which does supports macOS arm64 compilation (Reference)