Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display icons in roomlist for the 3 room types #258

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Oct 18, 2022

Issue : #186

Screen Shot 2022-10-18 at 5 04 57 PM

Tooltips when hovering on the icon :

image

image

image

@estellecomment
Copy link
Contributor Author

@areox-net Je continue de te tenir au courant, crie si quelque chose ne va pas :)

Review app (backend de dev, il faut un compte de dev, pas le compte de prod) : https://tchap-web-staging-v4-pr258.osc-secnum-fr1.scalingo.io/

@estellecomment estellecomment marked this pull request as ready for review October 18, 2022 15:39
@estellecomment
Copy link
Contributor Author

Our icons are not accessible for color-blind people : two of them have the same color.

@odelcroi odelcroi linked an issue Oct 18, 2022 that may be closed by this pull request
@areox-net
Copy link
Contributor

Our icons are not accessible for color-blind people : two of them have the same color.

That's true. However, they are used together with the related labels. Actually, today the "New Room" screen is the only place where they are displayed. So I don't think this is a bug issue.

Copy link
Contributor

@mcalinghee mcalinghee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@estellecomment estellecomment merged commit 9407225 into develop_tchap Oct 20, 2022
@odelcroi odelcroi deleted the 186-display-icon-for-all-room-types branch March 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roomlist displays private and public rooms in the same way
3 participants