Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roomlist displays private and public rooms in the same way #186

Closed
estellecomment opened this issue Sep 19, 2022 · 13 comments · Fixed by #166, #256 or #258
Closed

Roomlist displays private and public rooms in the same way #186

estellecomment opened this issue Sep 19, 2022 · 13 comments · Fixed by #166, #256 or #258
Assignees
Labels

Comments

@estellecomment
Copy link
Contributor

This is confusing for users. Both forums and private rooms are in the same section of roomlist, and with the same icon.

@github-actions github-actions bot added the web label Sep 19, 2022
@odelcroi odelcroi added P3 Priority 3 P2 Priority 2 and removed P3 Priority 3 labels Sep 21, 2022
@odelcroi odelcroi added P3 Priority 3 and removed P2 Priority 2 web labels Sep 28, 2022
@odelcroi
Copy link
Member

  • we do not see at a glance if a room allows external users

@odelcroi
Copy link
Member

@areox-net @Caroline-lawson Could we work on some UI components to enhance UX on this topic? Should we take the icon from V2 version?

@Caroline-lawson
Copy link

Another linked problem is that people I spoke with did not know that forums are not crypted conversations.

Remind me what the icon was in V2?

If it's the padlock, then it makes sense if it's on all types of group conversations. The problem is that the colours are counter intuitive :

  • red for private rooms: they are encrypted and therefore safe in the context of Tchap - a green closed padlock should make more sense here?
  • orange for private rooms open to external users: they are also encrypted - orange closed padlock?
  • green for forums: they are open to all Tchap users and not encrypted - red open padlock?

If it isn't the padlock - please ignore.

The "wave" icon didn't make much sense to the people I spoke to.

Open to other suggestions of course.

@areox-net
Copy link
Contributor

That's a recurring theme. Tchap v1 highlighted this difference by design, with avatar shapes, icons and - later - color labels for redundancy. We moved to a simpler roomlist as we moved toward Element.
After all these iterations, it is my opinion that the best solution is to separate Forums from other conversations. They are something different both in security level and use.
In this specific case, the web UI is particularly suited for this solution, since it already has sections.
Is it technically difficult to add a "Forums" section?

The problem still remains with external users. However, last time we talked about this it was decided that this information is relevant once we are inside a room rather than in the roomlist. So my proposal was to display this information in the room header, both on mobile and web.

@odelcroi
Copy link
Member

Is it technically difficult to add a "Forums" section?

I would say it is not straightfoward as we need to implement some logic in the right panel. I will investigate it, but in the mean time, could we propose a quick-win solution to be deployed in the coming days?

So my proposal was to display this information in the room header, both on mobile and web.
Sure, could you propose a design to do so?

@areox-net
Copy link
Contributor

@odelcroi A quick solution for now would be to use the same icon that we use on mobile for Forums
Screenshot 2022-10-12 at 11 41 40

For the header, my old proposals looked like this
Screenshot 2022-10-12 at 11 43 29

@odelcroi
Copy link
Member

odelcroi commented Oct 12, 2022

Thanks, what can be done easily is to replace the globe by the image you propose. Could you provide a svg version ?
Capture d’écran 2022-10-12 à 16 39 58

@areox-net
Copy link
Contributor

Here you go
icn_forum

@odelcroi odelcroi self-assigned this Oct 13, 2022
@mcalinghee mcalinghee linked a pull request Oct 13, 2022 that will close this issue
@estellecomment
Copy link
Contributor Author

estellecomment commented Oct 18, 2022

Question : Can we add a separate category in the roomlist, for public forums ?
Answer : not easily.

There is no provided hook to do this. We need to edit multiple files all over react-sdk.
The sections of the roomlist correspond to a list of tags defined in src/stores/room-list/models.ts. The tag for "Rooms" is "Untagged". We could add our extra tag "PublicRooms" there.
Then we need to edit a number of functions everywhere. Text-search for DefaultTagID.DM (the tag for DM category) gives a good idea of where to implement things. There is a complicated system with Algorith, events for modifications of the roomlist, etc.

Overall it will be hard to test that our customized roomlist works properly, and resists future upgrades of react-sdk.
If this is important we should push it into element-web directly.

@estellecomment
Copy link
Contributor Author

Implemented for forums :
image

While we're at it, we could also display the red lock on private rooms, and the orange lock on private-with-externs.

@Caroline-lawson
Copy link

Why didn't we change the colour of the padlocks?

  • Green for salons privés
  • Orange for salons privés ouverts aux externes
  • Red for forums

@estellecomment
Copy link
Contributor Author

@Caroline-lawson since then, we have ! #258

@Caroline-lawson
Copy link

I'm still not seeing it, but if you say it's there, great! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment