Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [fence-effects=""] to stop effect propagation #388

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

syg
Copy link
Contributor

@syg syg commented Dec 10, 2021

This allows for manual fencing where needed, like in GeneratorStart.

@bakkot
Copy link
Contributor

bakkot commented Dec 11, 2021

These are intended to be used only at the beginning of steps, yeah? We already have a different mechanism for metadata about steps, namely ids (which look like (1. [id="foo"] Step.); I'd prefer to reuse that (as in 1. [fences-effects="user-code"] Step.).

This would require a change to ecmarkdown; I can make that change if this approach sounds good to you.

@syg
Copy link
Contributor Author

syg commented Dec 11, 2021

These are intended to be used only at the beginning of steps, yeah? We already have a different mechanism for metadata about steps, namely ids (which look like (1. [id="foo"] Step.); I'd prefer to reuse that (as in 1. [fences-effects="user-code"] Step.).

Exactly right.

This would require a change to ecmarkdown; I can make that change if this approach sounds good to you.

I admit the only reason I did it this way is because I didn't want to touch ecmarkdown. If you're offering, doing it in ecmarkdown would be ideal.

@bakkot
Copy link
Contributor

bakkot commented Dec 14, 2021

Rebased on #392 and switched to the syntax suggested above.

src/Xref.ts Show resolved Hide resolved
@bakkot bakkot changed the title Add <emu-meta fence-effects="">...</emu-meta> to stop effect propagation Add [fence-effects=""] to stop effect propagation Dec 15, 2021
@bakkot bakkot merged commit ff18989 into tc39:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants