switch to step attribute

tc39 · Dec 14, 2021 · 9f8f797 · 9f8f797
1 parent 8b74851
commit 9f8f797
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/Xref.ts b/src/Xref.ts
@@ -111,14 +111,14 @@ export default class Xref extends Builder {
           return false;
         }
 
-        if (parent.children[0]) {
-          const child = parent.children[0];
-          if (
-            child.tagName === 'EMU-META' &&
-            child.getAttribute('fence-effects')?.includes(effectName)
-          ) {
-            return false;
-          }
+        if (
+          parent
+            .getAttribute('fence-effects')
+            ?.split(',')
+            .map(s => s.trim())
+            .includes(effectName)
+        ) {
+          return false;
         }
       }
       if (!this.clause.canHaveEffect(effectName)) {

diff --git a/test/baselines/generated-reference/effect-user-code.html b/test/baselines/generated-reference/effect-user-code.html
@@ -125,7 +125,7 @@ <h1><span class="secnum">20</span> ResultOfEvaluating()</h1>
 <emu-clause id="sec-fenced-effects" type="abstract operation" aoid="FencedEffects">
   <h1><span class="secnum">21</span> FencedEffects()</h1>
   <p>The abstract operation FencedEffects takes no arguments. Effects don't propagate past fences in parent steps. A fence must be at the beginning of a step. It performs the following steps when called:</p>
-  <emu-alg><ol><li>Fence.<ol><li><emu-xref aoid="UserCode" id="_ref_18"><a href="#sec-user-code" class="e-user-code">UserCode</a></emu-xref>().</li></ol></li></ol></emu-alg>
+  <emu-alg><ol><li fence-effects="user-code">Fence.<ol><li><emu-xref aoid="UserCode" id="_ref_18"><a href="#sec-user-code" class="e-user-code">UserCode</a></emu-xref>().</li></ol></li></ol></emu-alg>
 </emu-clause>
 
 <emu-clause id="sec-call-fenced-effects" type="abstract operation" aoid="CallFencedEffects">

diff --git a/test/baselines/sources/effect-user-code.html b/test/baselines/sources/effect-user-code.html
@@ -229,7 +229,7 @@ <h1>FencedEffects()</h1>
     <dd>Effects don't propagate past fences in parent steps. A fence must be at the beginning of a step.</dd>
   </dl>
   <emu-alg>
-    1. <emu-meta fence-effects="user-code"></emu-meta>Fence.
+    1. [fence-effects="user-code"] Fence.
       1. UserCode().
   </emu-alg>
 </emu-clause>