Editorial: quick fixes for recent merges #2129
Conversation
| 1. Set _r_.[[Key]] to ~empty~. | ||
| 1. Set _r_.[[Value]] to ~empty~. | ||
| 1. For each WeakSet _set_ such that _set_.[[WeakSetData]] contains _obj_, do | ||
| 1. Replace the element of _set_ whose value is _obj_ with an element whose value is ~empty~. | ||
| 1. Replace the element of _set_.[[WeakSetData]] whose value is _obj_ with an element whose value is ~empty~. |
There was a problem hiding this comment.
nice catch, this seems like an actual spec bug
|
@jmdyck do you think these commits could/should be combined, or do you think it's best if they remain separate? |
|
Generally I think it's best to keep commits separate when they perform independent changes, but in this case, if you combined them (and their commit messages), I think the result would be okay. If the Another possibility would be to combine commits that relate to the same PR-merge. (4 are for 2089, the last is for 1948) I can split/combine as you like. |
|
@jmdyck i think it makes sense to have one commit for each PR that's being fixed; but to also keep the spec bug as a separate one - so maybe 3 total? That'd be great, thanks :-) |
|
Done! |
|
(repushed to put the middle commit's points in a better order) |
Fixes spec bug from PR tc39#2089.
- Use title-case in clause heading - Tweak some algorithm syntax - Put 2 emu-clause attributes in quotes (We always quote element attributes -- see PR tc39#1868) - Change "a finalization registry object" to "a FinalizationRegistry" (The former term isn't defined.)
No description provided.