Editorial: Annex A tweaks #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 9, 2020
jmdyck
force-pushed
the
annex_a_tweaks
branch
2 times, most recently
from
698003b to
3dd9e0a
Compare
|
(force-pushed to resolve a merge conflict) |
ljharb
pushed a commit
that referenced
this pull request
Feb 21, 2020
... for consistency. (The vast majority of these are in Annex A.)
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 21, 2020
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 21, 2020
... to better match the order of productions in the main body.
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Feb 21, 2020
We're talking about
AsyncArrowFunction : CoverCallExpressionAndAsyncArrowHead
so change
CoverParenthesizedExpressionAndArrowParameterList
to
CoverCallExpressionAndAsyncArrowHead
ljharb
force-pushed
the
annex_a_tweaks
branch
from
3dd9e0a to
f7b8c79
Compare
|
i went ahead and pulled the markup commit directly into master, and rebased this PR on top. Please confirm that the diff looks correct. |
Looks correct to me. |
|
Should we just sort both lists? Are they already in some other order that I'm not aware of? |
Sort alphabetically? And what do you mean by "both" lists? This PR is about reducing inconsistencies between the main body and Annex A re the order of [defining] productions. I could imagine sorting Annex A, but what would it mean to sort the productions in the main body?
Annex A presents productions in roughly the same order as they appear in the main body. This PR reduces the roughness. We could eliminate order differences entirely if that's wanted. When I proposed these commits, I was just going for small changes that would allow me to continue. |
michaelficarra
approved these changes
Mar 12, 2020
syg
approved these changes
Mar 18, 2020
ljharb
approved these changes
Mar 18, 2020
... to better match the order of productions in the main body.
We're talking about
AsyncArrowFunction : CoverCallExpressionAndAsyncArrowHead
so change
CoverParenthesizedExpressionAndArrowParameterList
to
CoverCallExpressionAndAsyncArrowHead
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 9, 2020
(We always quote element attributes -- see PR tc39#1868)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 11, 2020
- Put 2 emu-clause attributes in quotes (We always quote element attributes -- see PR tc39#1868) - Use title-case in clause heading - Tweak some algorithm syntax - Change "a finalization registry object" to "a FinalizationRegistry" (The former term isn't defined.)
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 11, 2020
- Use title-case in clause heading - Tweak some algorithm syntax - Put 2 emu-clause attributes in quotes (We always quote element attributes -- see PR tc39#1868) - Change "a finalization registry object" to "a FinalizationRegistry" (The former term isn't defined.)
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Aug 11, 2020
- Use title-case in clause heading - Tweak some algorithm syntax - Put 2 emu-clause attributes in quotes (We always quote element attributes -- see PR tc39#1868) - Change "a finalization registry object" to "a FinalizationRegistry" (The former term isn't defined.)
h2oche
pushed a commit
to h2oche/ecma262
that referenced
this pull request
Aug 16, 2020
- Use title-case in clause heading - Tweak some algorithm syntax - Put 2 emu-clause attributes in quotes (We always quote element attributes -- see PR tc39#1868) - Change "a finalization registry object" to "a FinalizationRegistry" (The former term isn't defined.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks commits 4 - 7 of PR #1651. Their purpose is to reduce inconsistencies between the main body and Annex A (Grammar Summary), making it easier to keep them in synch going forward.