Normative: Add new BigInt primitive #1515

caiolima · 2019-04-23T19:43:03Z

This PR is include changes to integrate tc39/proposal-bigint into ECMA262 text. It contains changes on:

Grammar to support BigInt literals.
Abstract Operations to consider this new primitive.
Semantics of arithmetic expressions to support BigInts.
The specification of BigInt objects, including the constructor and BigInt.prototype.
Including BigInt64Array and BigUint64Array as new types of TypedArray.
Changes on DataView operations to support new types.

Proposal author: Daniel Ehrenberg and Brendan Eich

spec.html

annevk · 2019-04-24T11:06:20Z

Should this land after #1135?

littledan · 2019-04-24T11:09:32Z

@annevk Yes.

spec.html

jmdyck · 2019-04-26T19:07:29Z

I've got a bunch of suggested changes. I think it might be best to submit them as a PR against caiolima:big-int.

littledan · 2019-04-26T23:14:49Z

@jmdyck That's great to hear. Looking forward to seeing your PR.

jmdyck · 2019-04-29T02:46:50Z

Done: caiolima#3

littledan

LGTM!

It'd be great to have reviews from the editors for this PR ahead of the June 2019 TC39 meeting, where Caio and I plan to propose BigInt for Stage 4. cc @ljharb @zenparsing

caiolima · 2019-05-02T13:59:41Z

@littledan FYI, there are new changes from caiolima#4.

Formerly, the procedure for applying ToNumber to the String type was spread over three widely-separated prose paragraphs in two different clauses. This commit brings all that together, expresses it as an actual algorithm, and gives it the name StringToNumber. Similarly for the value of a NumericLiteral, here expressed as the syntax-directed operation NumericValue. This commit should provide better integration-points for PR tc39#1515 (BigInt).

ljharb · 2019-07-04T06:20:38Z

@caiolima i've merged #1135; can you rebase this?

Formerly, the procedure for applying ToNumber to the String type was spread over three widely-separated prose paragraphs in two different clauses. This commit brings all that together, expresses it as an actual algorithm, and gives it the name StringToNumber. Similarly for the value of a NumericLiteral, here expressed as the syntax-directed operation NumericValue. This commit should provide better integration-points for PR tc39#1515 (BigInt).

caiolima · 2019-07-05T13:50:30Z

@caiolima i've merged #1135; can you rebase this?

@ljharb done.

spec.html

ljharb · 2019-07-05T18:40:22Z

spec.html

+            <li>If _base_ &lt; 0 and _base_ is finite and _exponent_ is finite and _exponent_ is not an integer, the result is *NaN*.</li>
+          </ul>
+          <emu-note>
+            <p>The result of _base_ `**` _exponent_ when _base_ is *1* or *-1* and _exponent_ is *+Infinity* or *-Infinity* differs from IEEE 754-2008. The first edition of ECMAScript specified a result of *NaN* for this operation, whereas later versions of IEEE 754-2008 specified *1*. The historical ECMAScript behaviour is preserved for compatibility reasons.</p>


commenting here to note the interaction with #1609

spec.html

littledan · 2019-09-02T15:08:44Z

Given that you identify the concern as non-blocking, and you haven't made another suggestion, would it make sense to land this PR and be open to other editorial alternatives?

littledan · 2019-09-02T15:09:00Z

Thanks for the approval, BTW!

ljharb · 2019-09-02T15:10:08Z

It’ll need approval from the other editor first. My approval means that yes, it will land once it has approval from the full editor group.

jmdyck · 2019-09-17T21:21:56Z

spec.html

+
+        <emu-clause id="sec-numeric-types-bigint-subtract">
+          <h1>BigInt::subtract ( _x_, _y_ )</h1>
+          <p>The abstract operation BigInt::subtract with two arguments _x_ and _y_ of type BigInt returns the BigInt representing the difference _x_ minus _y_.</p>


Suggested change

<p>The abstract operation BigInt::subtract with two arguments _x_ and _y_ of type BigInt returns the BigInt representing the difference _x_ minus _y_.</p>

<p>The abstract operation BigInt::subtract with two arguments _x_ and _y_ of type BigInt returns the BigInt value that represents the difference _x_ minus _y_.</p>

... for consistency with my last commit. (I missed it because I was only looking for "a BigInt representing".)

spec.html

caiolima · 2019-09-24T19:33:51Z

@zenparsing is there anything else we need to do into this PR to get it merged?

This PR includes changes over current ECMA262 spec text to include a new primitive type called `BigInt`. This includes all changes necessary to integrate this new primitive in the language. It also includes changes on TypedArray, introducing `BigInt64Array` and `BigUint64Array` Changes during PR review: - Make NumberToBigInt(...) a sub-clause of BigInt(...) and put "Runtime Semantics:" in the header, otherwise it looks too much like a built-in function. (Analogous to Function() and CreateDynamicFunction()) - Rewrite the characteristics of the BigInt prototype object as a bulleted list. - Change 9x "of BigInt type" to "of type BigInt". Also, 1x "of BigInt" to "of type BigInt". - In the BigInt:: ops, change a few '0' to '*0n*'. - For some BigInt:: ops, change the preamble to a complete sentence - Rename "BitwiseOp" as "BigIntBitwiseOp" for symmetry with NumberBitwiseOp. Also, add an 'aoid' attribute to the clause. - Replace "ToString Applied to the BigInt Type" with "BigIntToString" - Rename 'NumericLiteralBase' to 'NonDecimalIntegerLiteral'. It more clearly expresses what it is, and it fits nicely with 'DecimalIntegerLiteral'. - Put 'thisBigIntValue' in a <dfn> element. - Mention '_littleEndian_' in preambles for setBigInt64, setBigUint64 - Tweak pseudocode in Atomics.compareExchange - Reference new productions from Annex A. - Reproduce changes to 'NumericLiteral' in Annex B. - Replace <a> element with <emu-xref> - In "Numeric Type Operations" table, split "Value and Purpose" into 3 columns - Add ::toString() as a numeric type operation. - In BigInt::toString, invoke BigInt::toString directly, rather than via ToString. - Changing the grammar for BigInt literals to disallow them for Annex-B non-octal digits (tc39/proposal-bigint#208) - Relocate new property-clauses (Specifically, properties of DataView.prototype and the BigInt constructor.) - Move some new abstract op clauses. - Delete NumberToString: you have Number::toString; ditto BigIntToString and BigInt::toString. - In the "Type Conversion" clause, rather than simply putting all the new abstract operations at the end, move them to more logical locations. - Change "TypedArrayType" to "ElementType". "TypedArrayType" (and "TypedArray type") suggests one of the TypedArray types, where we're really talking about one of the TypedArray *element* types. - Add 'oldids' attributes - Reference DecimalBigIntegerLiteral from Annex A - Use NonDecimalIntegerLiteral in StrNumericLiteral Co-authored-by: Caio Lima <[email protected]> Co-authored-by: Michael Dyck <[email protected]> Co-authored-by: Michael[tm] Smith <[email protected]>

caiolima · 2019-09-27T11:32:31Z

@ljharb and @zenparsing Thanks a lot for the review! @jmdyck and @littledan thx a lot for the fixes and reviews as well.

- Let -> Set - Eliminate otherwise-assertions (per tc39#1559) - Change '?' to '!', because ::subtract can't return an abrupt completion. - Fix bug: '_v_' should be '_value_' - Fix bug: `_arrayTypeName_` not defined ... in Atomics.{store,wait,notify}. (In Atomics.store, it does get defined in step 5, but needs to be defined before the reference in step 3.) (In Atomics.wait, the undefined reference is in step 11, but by defining it earlier, it can also be used in the current step 3.) (In Atomics.notify, the undefined reference is in step 7.)

- Update preamble for SetValueInBuffer and GetModifySetValueInBuffer; the `_value_` parameter can be a BigInt now. - tweak some BigInt-related element-ids

…teger' (tc39#1708) Fixes an unintentional spec bug from tc39#1515.

ljharb requested a review from littledan April 23, 2019 19:49

littledan added the has test262 tests label Apr 24, 2019

littledan reviewed Apr 24, 2019

View reviewed changes

spec.html Show resolved Hide resolved

littledan reviewed Apr 24, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

littledan reviewed Apr 24, 2019

View reviewed changes

spec.html Outdated Show resolved Hide resolved

littledan reviewed Apr 24, 2019

View reviewed changes

spec.html Show resolved Hide resolved

ljharb mentioned this pull request Apr 28, 2019

Extending defining out-of-memory beyond ArrayBuffer #1391

Open

littledan approved these changes May 2, 2019

View reviewed changes

jmdyck mentioned this pull request May 28, 2019

Editorial: Define + use StringToNumber #1554

Merged

zcei mentioned this pull request Jun 5, 2019

Add support for BigInt numeric atom/language-javascript#588

Merged

ljharb force-pushed the big-int branch from 383d96d to 43cda21 Compare June 6, 2019 16:55

caiolima mentioned this pull request Jun 6, 2019

Editorial: Explicitly note mathematical values #1135

Merged

mysticatea mentioned this pull request Jun 9, 2019

Does Acorn support Stage 3 now? acornjs/acorn#836

Closed

caiolima force-pushed the big-int branch from 43cda21 to 5fd98ab Compare June 14, 2019 23:24

littledan mentioned this pull request Jun 18, 2019

Typo getbituint64 -> getbiguint64 in ID/anchor tc39/proposal-bigint#206

Merged

caiolima force-pushed the big-int branch from c0a1357 to 1716862 Compare July 5, 2019 13:48

ljharb reviewed Jul 5, 2019

View reviewed changes

ljharb requested a review from a team September 2, 2019 15:05

jmdyck mentioned this pull request Sep 12, 2019

editorial caiolima/ecma262#7

Merged

caiolima force-pushed the big-int branch from d82e469 to 30a8039 Compare September 17, 2019 18:54

jmdyck reviewed Sep 17, 2019

View reviewed changes

spec.html Show resolved Hide resolved

zenparsing approved these changes Sep 26, 2019

View reviewed changes

ljharb self-assigned this Sep 27, 2019

ljharb force-pushed the big-int branch from 708c92a to fd3a260 Compare September 27, 2019 06:57

ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Sep 27, 2019

ljharb mentioned this pull request Sep 27, 2019

BigInt to stage 4 tc39/proposals#217

Merged

ljharb merged commit fd3a260 into tc39:master Sep 27, 2019

exoego mentioned this pull request Sep 28, 2019

Add js.BigInt for ES2019 (ES10) scala-js/scala-js#3786

Merged

3 tasks

caiolima mentioned this pull request Sep 30, 2019

Editorial: Changing 'SetViewValue' to use 'ToNumber' instead of 'ToInteger' #1708

Merged

ljharb pushed a commit to caiolima/ecma262 that referenced this pull request Sep 30, 2019

Normative: Changing 'SetViewValue' to use 'ToNumber' instead of 'ToIn…

a09c766

…teger' (tc39#1708) Fixes an unintentional spec bug from tc39#1515.

ljharb mentioned this pull request Oct 4, 2019

Editorial: fix intrinsic notation from previous PRs #1720

Merged

saschanaz mentioned this pull request Oct 8, 2019

Support bigint for ES2020 microsoft/TypeScript#33871

Closed

jmdyck mentioned this pull request Oct 16, 2019

Which specifications are related to ECMA262 #1738

Closed

devsnek mentioned this pull request Oct 26, 2019

Normative: Make BigInt a global #1753

Merged

caiolima mentioned this pull request Oct 31, 2019

Normative: Properly handle Number(BigInt) #1766

Merged

chicoxyzzy mentioned this pull request Nov 2, 2019

Editorial: Add BigInt to the list of primitive values #1769

Merged

bathos mentioned this pull request Nov 12, 2019

Editorial: Add BigInt to the list of reference base value types and the language types intro text #1773

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative: Add new BigInt primitive #1515

Normative: Add new BigInt primitive #1515

caiolima commented Apr 23, 2019 •

edited by littledan

Loading

annevk commented Apr 24, 2019

littledan commented Apr 24, 2019

jmdyck commented Apr 26, 2019

littledan commented Apr 26, 2019

jmdyck commented Apr 29, 2019

littledan left a comment

caiolima commented May 2, 2019

ljharb commented Jul 4, 2019

caiolima commented Jul 5, 2019

ljharb Jul 5, 2019

littledan commented Sep 2, 2019

littledan commented Sep 2, 2019

ljharb commented Sep 2, 2019 •

edited

Loading

jmdyck Sep 17, 2019

caiolima commented Sep 24, 2019

caiolima commented Sep 27, 2019

	<p>The abstract operation BigInt::subtract with two arguments _x_ and _y_ of type BigInt returns the BigInt representing the difference _x_ minus _y_.</p>
	<p>The abstract operation BigInt::subtract with two arguments _x_ and _y_ of type BigInt returns the BigInt value that represents the difference _x_ minus _y_.</p>

Normative: Add new BigInt primitive #1515

Normative: Add new BigInt primitive #1515

Conversation

caiolima commented Apr 23, 2019 • edited by littledan Loading

annevk commented Apr 24, 2019

littledan commented Apr 24, 2019

jmdyck commented Apr 26, 2019

littledan commented Apr 26, 2019

jmdyck commented Apr 29, 2019

littledan left a comment

Choose a reason for hiding this comment

caiolima commented May 2, 2019

ljharb commented Jul 4, 2019

caiolima commented Jul 5, 2019

ljharb Jul 5, 2019

Choose a reason for hiding this comment

littledan commented Sep 2, 2019

littledan commented Sep 2, 2019

ljharb commented Sep 2, 2019 • edited Loading

jmdyck Sep 17, 2019

Choose a reason for hiding this comment

caiolima commented Sep 24, 2019

caiolima commented Sep 27, 2019

caiolima commented Apr 23, 2019 •

edited by littledan

Loading

ljharb commented Sep 2, 2019 •

edited

Loading