Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial #7

Merged
merged 6 commits into from
Sep 17, 2019
Merged

editorial #7

merged 6 commits into from
Sep 17, 2019

Conversation

jmdyck
Copy link

@jmdyck jmdyck commented Sep 12, 2019

A few more editorial changes for PR tc39#1515.

... and express the latter as a proper syntax-directed operation.

(This also accomplishes some of PR tc39#1554.)
"a" -> "the" because the value is uniquely determined.

"BigInt" -> "BigInt value" because that's (more or less) the convention.

"representing" -> "the represents" because I think it reads better,
but I could maybe be persuaded otherwise.
1. If _op_ is `"&"`, let _tmp_ be BinaryAnd(x modulo 2, y modulo 2).
1. Else if _op_ is `"|"`, let _tmp_ be BinaryOr(x modulo 2, y modulo 2).
1. If _op_ is `"&"`, let _tmp_ be BinaryAnd(_x_ modulo 2, _y_ modulo 2).
1. Else if _op_ is `"|"`, let _tmp_ be BinaryOr(_x_ modulo 2, _y_ modulo 2).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Nice catch.

Copy link
Owner

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiolima caiolima merged commit d82e469 into caiolima:big-int Sep 17, 2019
@jmdyck jmdyck deleted the 1515_ed branch September 30, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants