Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate dirs_next to dirs #9929

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented May 31, 2024

Reference: #6063

@Legend-Master
Copy link
Contributor Author

I'm not familiar with the changes dirs made in version 3 and 4 (config_dir is changed on Mac, executable_dir $XDG_DATA_HOME changed on Linux), need some help on those 2

@amrbashir
Copy link
Member

config_dir is changed on Mac

Looking at https://docs.rs/dirs-next/latest/dirs_next/fn.config_dir.html vs https://docs.rs/dirs/latest/dirs/fn.config_dir.html, they look the same, no?

executable_dir $XDG_DATA_HOME changed on Linux

Same, https://docs.rs/dirs-next/latest/dirs_next/fn.executable_dir.html vs https://docs.rs/dirs/latest/dirs/fn.executable_dir.html.

Am I missing something obvious here?

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 4, 2024

Ah, never mind the mac one, it's already changed to this directory in dirs-next 2.0, it's a breaking change in dirs 3.0, didn't look too closely at the time

About the linux one, I just don't know what does this mean, maybe there's nothing to be worried about

BREAKING CHANGE The behavior of executable_dir has been adjusted to not depend on $XDG_DATA_HOME. Code, which assumed that setting the $XDG_DATA_HOME environment variable also impacted executable_dir if the $XDG_BIN_HOME environment variable was not set, requires adjustment.

@Legend-Master Legend-Master marked this pull request as ready for review June 4, 2024 01:21
@Legend-Master Legend-Master requested a review from a team as a code owner June 4, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants