-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] replace unmaintained dirs_next
crate
#6063
Comments
We talked about this some weeks or months ago and concluded that it's not worth switching because the alternatives are not much more maintained either. |
Yeah I remember, so basically my point is that Edit: Oh and that we can upstream Android support to |
So it's not about the "next" and non-next crates, but dirs vs directories which i guess is fair but could be fixed by us by just not using the bundle id in the appDir functions. (Or are there other diffs between next and non-next in the paths in general like when comparing the "same" functions between crates? Can't compare them on my phone) |
Yeah, so I just double checked and it seems that both crates return the same paths for all other functions, the only difference is in the app-scoped directories. Edit: To be fair we don't need to use But the big advantage would be that we could finally add Android support. especially |
I decided that we can keep the Android implementation of the paths module in-tree for now, see #6068. We can decide on changing the crate used (and the way we construct the app dir) for v2 |
I am fine with moving back to |
Here's the discussion i was talking about in my first comment: https://discord.com/channels/616186924390023171/807549941936816148/1039492950075379713 / tauri-apps/tao#615 (comment) which was about |
Describe the problem
The
dirs_next
crate used in thetauri::api::path
module is unmaintained since 2021-ish see here and here.Describe the solution you'd like
Replace
dirs_next
withdirectories
. This has the added benefit thatdirectories::ProjectDirs
creates proper app-scoped paths for each supported OS. Example:Our current
dirs_next
implementation returns{FOLDERID_RoamingAppData}\{bundleIdentifier}
fromapp_dir()
whiledirectories::ProjectDirs::app_data()
returns the proper{FOLDERID_RoamingAppData}\{Organization}\{ProductName}\data
.directories
also enforces proper paths throughProjectDirs
constructor.HOWEVER: This would introduce a breaking change, as paths returned by
directories
are not the same as paths returned fromdirs_next
.Alternatives considered
There are a number of alternatives to
dirs_next
, but all seem to recommenddirectories
in the end.Additional context
This is closely related with #6062 which would also introduce a breaking change.
The text was updated successfully, but these errors were encountered: