Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dirs-next crate is unmaintained, use dirs instead #7459

Closed
wants to merge 1 commit into from
Closed

chore: dirs-next crate is unmaintained, use dirs instead #7459

wants to merge 1 commit into from

Conversation

developomp
Copy link

@developomp developomp commented Jul 19, 2023

Closes #6063

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Links:

@developomp developomp requested a review from a team as a code owner July 19, 2023 16:26
@FabianLars
Copy link
Member

Thanks for contributing! You forgot to update the crate version though, it's 5.0 i think. Also i'm not 100% sure but i think we'll also need a changefile for this :)
And lastly, you may wanna target the 1.x branch instead of dev.

@developomp
Copy link
Author

I will open another PR tomorrow

@developomp developomp closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

[feat] replace unmaintained dirs_next crate
2 participants