Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): team ID is now required for notarytool via app password #7972

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 6, 2023 15:50
FabianLars
FabianLars previously approved these changes Oct 6, 2023
@FabianLars
Copy link
Member

(should have waited with the approval. i forgot that it gets dismissed on each commit. see you after you fixed ci 😂)

@lucasfernog lucasfernog merged commit 40d3400 into 1.x Oct 6, 2023
34 checks passed
@lucasfernog lucasfernog deleted the fix/team-id-required branch October 6, 2023 17:33
lucasfernog added a commit that referenced this pull request Oct 8, 2023
lucasfernog added a commit that referenced this pull request Oct 8, 2023
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
Co-authored-by: lucasfernog <[email protected]>
fix(bundler): team ID is now required for notarytool via app password (#7972)
fix(bundler): team ID is now required for notarytool via app password (#7972)"
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
lucasfernog-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 23, 2023
* feat(macos): add team_id option for apple notarization
Port of tauri-apps/tauri#7775

Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>

* fix(macos): fix notraytool's apple-id option name
Port of tauri-apps/tauri#7934

Co-authored-by: Jason Tsai <[email protected]>
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>

* fix(macos): team ID is now required for notarytool via app password
Port of tauri-apps/tauri#7972

Co-authored-by: Lucas Fernandes Nogueira <[email protected]>

* refactor: remove Error::MissingNotarizeAuthTeamId

Co-authored-by: Lucas Nogueira <[email protected]>

---------

Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: Jason Tsai <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants