Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team_id option for apple notarization #7775

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

tr3ysmith
Copy link
Contributor

What kind of change does this PR introduce?

Adds an optional APPLE_TEAM_ID variable to notarization on MacOS when using Apple ID and Password authentication. This is useful if people belong to multiple teams.

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@tr3ysmith tr3ysmith requested a review from a team as a code owner September 7, 2023 14:51
@tr3ysmith tr3ysmith changed the title add team_id option feat: add team_id option for apple notarization Sep 7, 2023
@lucasfernog lucasfernog merged commit 2f8881c into tauri-apps:1.x Sep 15, 2023
14 checks passed
@tr3ysmith tr3ysmith deleted the add-team-id branch September 15, 2023 13:08
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
lucasfernog-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 23, 2023
* feat(macos): add team_id option for apple notarization
Port of tauri-apps/tauri#7775

Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>

* fix(macos): fix notraytool's apple-id option name
Port of tauri-apps/tauri#7934

Co-authored-by: Jason Tsai <[email protected]>
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>

* fix(macos): team ID is now required for notarytool via app password
Port of tauri-apps/tauri#7972

Co-authored-by: Lucas Fernandes Nogueira <[email protected]>

* refactor: remove Error::MissingNotarizeAuthTeamId

Co-authored-by: Lucas Nogueira <[email protected]>

---------

Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: Jason Tsai <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants