-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Returns a warning instead of panicking if an AppImage is not mounted, closes #7736 #7843
Conversation
...close ;-) This is what actually happens: When submitting an AppImage to https://appimage.github.io/, then the automated test in that repository checks if the AppImage is valid by trying to run it with Firejail. And since Tauri makes some assumptions about AppImages that do not hold true (and are not part of the spec), Firejail currently fails to run AppImages made with Tauri, preventing Tauri-based AppImages from passing the automated test. So it would be best to entirely reverse-apply 6fbd6db since its assumptions are flawed to begin with. |
…nted, closes #7736 (#7843) Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
When uploading an AppImage to the AppImage repository, Tauri checks if the AppImage is valid by trying to mount it and check a specific mount point. Unfortunately, many AppImages that are perfectly functional don't pass this test, and therefore the automatic AppImage Workflow fails.
To fix this issue, I simply replaced the panic with a warning. This would still give feedback, but at least let the AppImage finish running. I encountered this issue here and mayn other users have as well in the issue #7736
Basically, I am reverting some changes of the commit: 6fbd6db
Note: I used the log crate to display a warning, but if that's not ok with you, you are more than welcome to change that.