Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] AppImage fails to run due to misguided "validation" #7736

Closed
probonopd opened this issue Sep 2, 2023 · 1 comment
Closed

[bug] AppImage fails to run due to misguided "validation" #7736

probonopd opened this issue Sep 2, 2023 · 1 comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@probonopd
Copy link

probonopd commented Sep 2, 2023 •
edited
Loading

Describe the bug

6fbd6db ("validate AppImage execution when env vars are set") introduces a "validation" that makes unreasonable assumptions, and as a result the AppImage does not work as it should:

thread 'main' panicked at '`APPDIR` or `APPIMAGE` environment variable found but this application was not detected as an AppImage; this might be a security issue.', (...)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

References:

Reproduction

  • Try to run the AppImage using Firejail
  • Extract the AppImage to an AppDir using --appimage-extract, then run it using ./squashfs-root/AppRun

Expected behavior

The application runs.

Platform and versions

I can't run commands; the result is from an automated test that can be seen at the URL below.

Stack trace

https://github.com/AppImage/appimage.github.io/actions/runs/6060923178/job/16445575611#step:4:386

Additional context

Nothing in the AppImageSpec suggests or guarantees that an AppImage gets mounted to a mountpoint of any sort of predictable path. Just because one particular version of the AppImage runtime had a certain behavior it cannot be deduced that this is universally true; e.g., when using Firejail it is not.
@probonopd probonopd added status: needs triage This issue needs to triage, applied to new issues type: bug labels Sep 2, 2023
This was referenced Sep 15, 2023
Closed
Open
Open
This was referenced Sep 15, 2023
Closed
Merged
@probonopd
Copy link
Author

As a fix, please reverse-apply

https://github.com/tauri-apps/tauri/commit/6fbd6dba5290dc017ab0ba5a44cf4358b022836f.diff

lucasfernog added a commit that referenced this issue Sep 28, 2023
@Benji377 @lucasfernog
fix: Returns a warning instead of panicking if an AppImage is not mou…
867883e 
…nted, closes #7736 (#7843)

Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
lucasfernog added a commit that referenced this issue Sep 28, 2023
@lucasfernog @Benji377
fix: Returns a warning instead of panicking if an AppImage is not mou…
c68fbfc 
…nted, closes #7736 (#7912)

Co-authored-by: Benjamin Demetz <[email protected]>
@probonopd probonopd mentioned this issue Oct 28, 2023
Open
@GetPsyched GetPsyched mentioned this issue Nov 28, 2023
Closed
1 task
@Erudition Erudition mentioned this issue Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probonopd