Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): disable action bar in themes.xml #7164

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 8, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 8, 2023 11:39
wusyong
wusyong previously approved these changes Jun 8, 2023
@lucasfernog
Copy link
Member

Is this really what most people will want? AFAIK flutter and capacitor doesn't do this by default.

@amrbashir
Copy link
Member Author

I don't really know, but I kinda hate the hard coded values.

@amrbashir
Copy link
Member Author

Btw I was going to make it fully transparent but backed out of it because it would look awful without also making the navigation bar also transparent and instead decided to just make it translucent which should work fine in most of cases and blend good enough with the user app by default.

Users can still remove this bit and customize it as they want for their app.

Also I have seen more and more Android apps moving towards transparent status bar (and navigation bar). I have a friend who works in Android native and he has noticed this trend as well.

@wusyong
Copy link
Member

wusyong commented Jun 8, 2023

I added previous stuff because that's the only sensible default that many android dev could agree on.
But that's indeed not the case in many scenarios. I think the best we should do is advise users to edit the theme they prefer.
Therese not such thing for default value and we can't control it.

@amrbashir amrbashir changed the title feat(android): translucent statusbar, closes #7052 feat(android): disable action bar in themes.xml Jun 8, 2023
@amrbashir
Copy link
Member Author

Alright, I just removed all the colors and kept the default. I only added the change to hide the action bar.

@lucasfernog
Copy link
Member

Transparent navigation bar looks amazing, but I think it might also impact the app more (last time I wrote a native Android app I took me ages to get it perfect).

@amrbashir
Copy link
Member Author

Yeah, I think it will either be a good community plugin or we could just link to a documentation or something and users implement it if they needed it

@lucasfernog lucasfernog changed the base branch from next to dev June 16, 2023 15:14
@lucasfernog lucasfernog merged commit 8922be5 into dev Jun 16, 2023
@lucasfernog lucasfernog deleted the feat/android/transparent-status-bar branch June 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants