-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): disable action bar in themes.xml
#7164
Conversation
Is this really what most people will want? AFAIK flutter and capacitor doesn't do this by default. |
I don't really know, but I kinda hate the hard coded values. |
Btw I was going to make it fully transparent but backed out of it because it would look awful without also making the navigation bar also transparent and instead decided to just make it translucent which should work fine in most of cases and blend good enough with the user app by default. Users can still remove this bit and customize it as they want for their app. Also I have seen more and more Android apps moving towards transparent status bar (and navigation bar). I have a friend who works in Android native and he has noticed this trend as well. |
I added previous stuff because that's the only sensible default that many android dev could agree on. |
themes.xml
Alright, I just removed all the colors and kept the default. I only added the change to hide the action bar. |
Transparent navigation bar looks amazing, but I think it might also impact the app more (last time I wrote a native Android app I took me ages to get it perfect). |
Yeah, I think it will either be a good community plugin or we could just link to a documentation or something and users implement it if they needed it |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information