Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] option to hide android action bar #971

Closed
1 of 2 tasks
jhutchins opened this issue Jun 11, 2023 · 2 comments
Closed
1 of 2 tasks

[feat] option to hide android action bar #971

jhutchins opened this issue Jun 11, 2023 · 2 comments

Comments

@jhutchins
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I know there was a recent change to default to having the action bar on Android (#968), but I would like the ability to configure it without needing to add kotlin code or android configs for my project. I assume some people want it and other don't.

Describe the solution you'd like
I would like whether to have this or not be a configuration on the window builder.

Describe alternatives you've considered
Obviously we could make it so uses need to create their own base kotlin class where they override the value or apply a themes.xml file, but I think that a config option would be better.

Would you want to assign yourself to implement this feature?

  • Yes
  • No

Additional context
If this feature were in place then there could be an option in the tauri config for whether to have the action bar or not. Probably it would default to on (as is the Android default), but it could be a simple boolean there.

@amrbashir
Copy link
Member

I am against this tbh, WRY is supposed to be a lower-level library with bare minimum features, and I don't see any major blocker preventing WRY users from applying this change in their project, either through themes.xml or by inheriting WryActivity class and calling the needed method there.

I should also note that while #968 removes it from WRY, it will still be added by default for Tauri see tauri-apps/tauri#7164

@jhutchins
Copy link
Contributor Author

That works for my use case.

@jhutchins jhutchins closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants