Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundler/NSIS): Add Japanese to supported NSIS languages. Partially fixes #6906. #6940

Merged
merged 1 commit into from
May 11, 2023
Merged

feat(bundler/NSIS): Add Japanese to supported NSIS languages. Partially fixes #6906. #6940

merged 1 commit into from
May 11, 2023

Conversation

nathan-fall
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Relevant issue: #6906
Relevant PR: #6907

@nathan-fall nathan-fall requested a review from a team as a code owner May 11, 2023 05:31
@nathan-fall nathan-fall mentioned this pull request May 11, 2023
Closed
FabianLars
FabianLars approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FabianLars FabianLars merged commit b257beb into tauri-apps:dev May 11, 2023
@Mehrbod2002 Mehrbod2002 mentioned this pull request May 15, 2023
Merged
13 tasks
This was referenced May 19, 2023
Closed
Merged
@FabianLars FabianLars mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathan-fall @FabianLars