Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add Japanese to the nsis language. #7113

Closed
t0m0120 opened this issue Jun 2, 2023 · 3 comments
Closed

[feat] add Japanese to the nsis language. #7113

t0m0120 opened this issue Jun 2, 2023 · 3 comments

Comments

@t0m0120
Copy link

t0m0120 commented Jun 2, 2023

Describe the problem

I get the following error when I set japanese to windows>nsis>language in tauri.conf.json

  "tauri": {
     ....
      "windows": {
        "nsis": {
          "languages": ["japanese"]
        }
      }

build error

       Error failed to bundle project: Language japanese not implemented. If it is a valid language listed on <https://github.com/kichik/nsis/tree/9465c08046f00ccb6eda985abbdbf52c275c6c4d/Contrib/Language%20files>, please open a Tauri feature request

Describe the solution you'd like

I would like to see Japanese added to the nsis build.

Alternatives considered

No response

Additional context

No response

@FabianLars
Copy link
Member

Japanese was added into the cli in v1.3.1: #6940 but it's currently broken with a fix being here: #7086 - thanks for the request :)

@FabianLars FabianLars closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
@t0m0120
Copy link
Author

t0m0120 commented Jun 3, 2023

@FabianLars
Thanks for the comment.
Is there a way to apply the #7086 modifications on local?

@FabianLars
Copy link
Member

You'll have to use the CLI from git, here's a small guide showing you how: https://tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants