Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioner): pass correct values through IPC #1858

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

amrbashir
Copy link
Member

followup to #1822

@amrbashir amrbashir requested a review from a team as a code owner October 2, 2024 00:35
Copy link

socket-security bot commented Oct 2, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@tauri-apps/[email protected]

View full report↗︎

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Package Changes Through 3eb3fa9

There are 11 changes which include cli with prerelease, deep-link with prerelease, dialog with prerelease, sql with prerelease, fs with prerelease, positioner with prerelease, positioner-js with prerelease, shell with prerelease, store-js with prerelease, store with prerelease, updater with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-rc.7 2.0.0-rc.8
api-example-js 2.0.0-rc.4 2.0.0-rc.5
cli 2.0.0-rc.1 2.0.0-rc.2
deep-link 2.0.0-rc.6 2.0.0-rc.7
fs 2.0.0-rc.5 2.0.0-rc.6
dialog 2.0.0-rc.7 2.0.0-rc.8
http 2.0.0-rc.5 2.0.0-rc.6
persisted-scope 2.0.0-rc.5 2.0.0-rc.6
positioner 2.0.0-rc.1 2.0.0-rc.2
positioner-js 2.0.0-rc.1 2.0.0-rc.2
shell 2.0.0-rc.3 2.0.0-rc.4
single-instance 2.0.0-rc.4 2.0.0-rc.5
sql 2.0.0-rc.2 2.0.0-rc.3
store 2.0.0-rc.3 2.0.0-rc.4
store-js 2.0.0-rc.1 2.0.0-rc.2
updater 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit 654a729 into v2 Oct 2, 2024
11 checks passed
@lucasfernog lucasfernog deleted the fix/positioner/values-through-ipc branch October 2, 2024 11:28
gezihuzi pushed a commit to Hypobenthos/plugins-workspace that referenced this pull request Oct 3, 2024
* fix(positioner): pass correct values through IPC

followup to tauri-apps#1822

* build api & remove packageManager field
@lucasfernog-crabnebula
Copy link
Contributor

I actually think this broke the impl - we expect a PhysicalPosition and not a Position in the command, reverted on #1911

Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
* fix(positioner): pass correct values through IPC

followup to tauri-apps#1822

* build api & remove packageManager field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants