[positioner] handleIconState in JS #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through ad3e1c6There are 8 changes which include cli with prerelease, deep-link with prerelease, dialog with prerelease, sql with prerelease, fs with prerelease, positioner with prerelease, positioner-js with prerelease, updater with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I think our types might be wrong here. |
|
@jbolda that is indeed the case, the Rust type is actually an enum: enum Position {
Physical { .. },
Logical { .. },
}and it will be serialized into {
"Physical or Logical": { .. }
}So we need to at runtime, convert these values into the JS |
amrbashir
added a commit
to tauri-apps/tauri
that referenced
this pull request
Sep 24, 2024
lucasfernog
added a commit
to tauri-apps/tauri
that referenced
this pull request
Sep 24, 2024
#11104) * fix(api): convert `Position` to `PhsyicalPosition` for `TrayIconEvent` ref: tauri-apps/plugins-workspace#1822 (comment) * fix lint * Add missing `doubleClick` event type * change file * update lockfile * Update .changes/api-tray-icon-event-value-mismatch-type.md [skip ci] --------- Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
lucasfernog
approved these changes
Oct 1, 2024
amrbashir
added a commit
that referenced
this pull request
Oct 2, 2024
lucasfernog
pushed a commit
that referenced
this pull request
Oct 2, 2024
* fix(positioner): pass correct values through IPC followup to #1822 * build api & remove packageManager field
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Oct 3, 2024
* [positioner] handleIconState in JS * update readme * fix change file version * fixes --------- Co-authored-by: Lucas Nogueira <[email protected]>
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Oct 3, 2024
* fix(positioner): pass correct values through IPC followup to tauri-apps#1822 * build api & remove packageManager field
|
Looks like the JS vs Rust have a mismatch last commit. /cc @lucasfernog |
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
* [positioner] handleIconState in JS * update readme * fix change file version * fixes --------- Co-authored-by: Lucas Nogueira <[email protected]>
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
* fix(positioner): pass correct values through IPC followup to tauri-apps#1822 * build api & remove packageManager field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to handle events to update the icon state in this plugin. Previously, we could only do this in Rust, which meant it was not possible create the TrayIcon in JS with an
action. This adds a function to handle the same.