Added quotes for cmd #1806
Merged
Added quotes for cmd #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 9e9464aThere are 1 changes which include deep-link with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
Sep 19, 2024
Legend-Master
approved these changes
Sep 19, 2024
|
Thanks |
|
@Legend-Master did you check whether is_registered still works? |
|
Oops, didn't know we actually check the registry value instead of checking if it exists, I'll make PR to fix that |
|
yeah that's to try to not return true when another app handles that same scheme (though that may need an explicit return type as simply overwriting would be a bit messed up) |
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
* Added quotes for cmd * Add change file --------- Co-authored-by: Tony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1804