Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Application path for cmd in Windows registry needs to be wrapped in quotes #1804

Closed
co-p opened this issue Sep 18, 2024 · 0 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers plugin: deep-link

Comments

@co-p
Copy link

co-p commented Sep 18, 2024

On Windows 10/11, when a protocol/scheme is registered, the application path for the cmd is not wrapped in quotes, which fails if the application path contains spaces.

Should be an easy fix in line 281 of .../plugins/deep-link/src/lib.rs

change: cmd_reg.set_string("", &format!("{} \"%1\"", &exe))?;
to: cmd_reg.set_string("", &format!("\"{}\" \"%1\"", &exe))?;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers plugin: deep-link
Projects
None yet
Development

No branches or pull requests

3 participants