feat(flow): add ignoreDependencyOnFailure option #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
idof-feat
branch
from
0b73bfd to
35582a4
Compare
manast
approved these changes
Feb 16, 2024
| @@ -50,11 +51,21 @@ local function removeJob( prefix, jobId, parentKey, removeChildren) | |||
| removeJob( childJobPrefix, childJobId, jobKey, removeChildren ) | |||
| end | |||
| end | |||
|
|
|||
| local failed = rcall("HGETALL", jobKey .. ":failed") | |||
There was a problem hiding this comment.
This call could potentially require a lot of memory and resources if the number of failed jobs is very large. A solution would be to use "https://redis.io/commands/hlen/" first, and if the len is larger than a specific size, maybe 100 or so, start a iteration process. Obviously this is going to be complicated in general as the iteration would need to be done by calling "removeJob" iteratively... Maybe it is not critical to get this done in this PR, but we should mark it in an issue as a known issue/future enhancement.
There was a problem hiding this comment.
I referenced one issue to remember this improvement
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2024
# [5.2.0](v5.1.12...v5.2.0) (2024-02-17) ### Features * **flow:** add ignoreDependencyOnFailure option ([#2426](#2426)) ([c7559f4](c7559f4))
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2092 #800