Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get failedChildren when using removeDependencyOnFailure #2092

Closed
M3talen opened this issue Jul 24, 2023 · 5 comments
Closed

Get failedChildren when using removeDependencyOnFailure #2092

M3talen opened this issue Jul 24, 2023 · 5 comments

Comments

@M3talen
Copy link

M3talen commented Jul 24, 2023

Is your feature request related to a problem? Please describe.
After the v4.4.0 update including the removeDependencyOnFailure feature (#1953) we can start a flow and upon completion we can get the parent job from the flowProducer that consists of a job object and a array of children. When using the removeDependencyOnFailure when a job fails, that job is not anymore in the children array.
image

Describe the solution you'd like
Would it be possible to include a new array of failed children ? Looking through the jobs i can see that the job is not removed from redis.

Describe alternatives you've considered
Using the failed event i can get the top level parent of a job and update a failed array in its data field. This doesn't seem like a reliable way to handle this.

Additional context
Any way to get the failed children from a flow would be great.

@prolific
Copy link

I too would love to have this option. I am building a flow of jobs where each one of them runs a specific set of tests against our system on a daily basis. I am already using removeDependencyOnFailure which is really very helpful but I also want to know the list of all the failed children along with the error information stored inside them because I want to either store this data in database or trigger mails based on all this information.

Is there a way to at least get the original list of job ids (including those that failed)? Maybe we can simply loop through them and fetch the required information?

@roggervalf
Copy link
Collaborator

hey folks, ignoreDependencyOnFailure feature is available since v5.2.0

@lltr
Copy link

lltr commented Aug 15, 2024

hey folks, ignoreDependencyOnFailure feature is available since v5.2.0

May I check if this option ignores failures for only direct child dependencies or does it also continue to run if grandchildren and nested dependencies fail if I put the option at the top level?

@roggervalf
Copy link
Collaborator

hi @lltr, this option ignore the failure of that specific child, it only affect the child and the direct parent no other components of the flow

@roggervalf
Copy link
Collaborator

pls take a look https://docs.bullmq.io/guide/flows/ignore-dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants