Amend RFC#139 to reduce 40 to 38, omit org/repo #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once this RFC was resolved and Ojas began implementation, it turned out there were some technical issues with it, not least of which that I had done the math wrong and 40 characters is too much. Also, as mentioned in the PR comments, organization and repository are already allowed to be 100 characters, so they are removed from consideration here.
djmitche
requested review from
jhford,
helfi92,
imbstack,
owlishDeveloper,
petemoore and
walac
imbstack
approved these changes
Feb 7, 2019
helfi92
approved these changes
Feb 7, 2019
walac
approved these changes
Feb 7, 2019
owlishDeveloper
approved these changes
Feb 8, 2019
petemoore
approved these changes
Feb 8, 2019
jhford
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #139 was resolved and Ojas began implementation, it turned out
there were some technical issues with it, not least of which that I had
done the math wrong and 40 characters is too much. Also, as mentioned
in the PR comments, organization and repository are already allowed to
be 100 characters, so they are removed from consideration here.