-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase identifier length from 20 to 44 #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, finally! God blesses you!
rfcs/0139-longer-identifiers.md
Outdated
* `schedulerId` | ||
* `organization`, `repository` (in tc-github) | ||
|
||
* "slugids" -- up to 22 characters, always a slugid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slugids are always 22 characters right? for those identifiers which are slugids, we should validate that they're valid slugids, or else they'd be plain identifiers that just aren't 40 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right -- I'll change that to "exactly 22". It's already validated.
I'll leave this until early next week when @helfi92 and @owlishDeveloper are back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
OK! I'll land this on Thursday, unless there are comments during the final-comment period. |
@OjaswinM noted that github's |
No description provided.