Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console wallet] Transaction details wording does not reflect Tari address but public key #5017

Closed
hansieodendaal opened this issue Dec 7, 2022 · 2 comments · Fixed by #5025
Closed

[console wallet] Transaction details wording does not reflect Tari address but public key #5017

hansieodendaal opened this issue Dec 7, 2022 · 2 comments · Fixed by #5025

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Dec 7, 2022 •
edited
Loading

On:

  • Transactions Details pane
  • Completed Transactions pane
  • Pending Transactions pane
@hansieodendaal hansieodendaal converted this from a draft issue Dec 7, 2022
@SWvheerden
Copy link
Collaborator

SWvheerden commented Dec 8, 2022 •
edited
Loading

#4939
The tx tab needs some love

@SWvheerden SWvheerden mentioned this issue Dec 8, 2022
Merged
@SWvheerden
Copy link
Collaborator

closing this as is duplicate of issue #4939

@github-project-automation github-project-automation bot moved this from Bugs to Done in Tari Esme Testnet Jan 5, 2023
stringhandler pushed a commit that referenced this issue Jan 5, 2023
@SWvheerden
fix: console wallet spacing and naming (#5025)
e4a6303 
Description
---
Fixes the spacing of the TariAddress field in the transactions panel
Fixes the naming of the Tari address from the public key

Motivation and Context
---
These have been wrong since the update to tari address. The naming was missed when updating, and because the tari address is 2 char's longer, the spacing was out. 

How Has This Been Tested?
---
Manual


Fixes: #5018
Fixes: #5017
Fixes: #4939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: console wallet spacing and naming SWvheerden/tari
2 participants
@SWvheerden @hansieodendaal