Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console Wallet TUI transaction tab needs rescaling #4939

Closed
SWvheerden opened this issue Nov 21, 2022 · 2 comments · Fixed by #5025
Closed

Console Wallet TUI transaction tab needs rescaling #4939

SWvheerden opened this issue Nov 21, 2022 · 2 comments · Fixed by #5025
Assignees
@SWvheerden
Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue. E-good_first_issue Experience Level - Good for newcomers
Milestone
Stagenet Freeze

Comments

@SWvheerden
Copy link
Collaborator

Since the update to use Tari Address rather than just public keys as addresses for the wallet, the transaction tab needs a rescaling to show a clear gap between address and amount
Screenshot 2022-11-21 at 17 33 21
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. E-good_first_issue Experience Level - Good for newcomers A-wallet Area - related to the wallet labels Nov 21, 2022
@stringhandler
Copy link
Collaborator

I suggest these changes as well:

  1. Shorten the pub key in the list, and add the pub keys as well as the emoji id's to the details pane

@stringhandler stringhandler moved this to Selected for development in Tari Esme Testnet Nov 28, 2022
@stringhandler stringhandler added this to the Stagenet Freeze milestone Nov 28, 2022
@SWvheerden
Copy link
Collaborator Author

Source/destination public key text is wrong as well

This was referenced Dec 8, 2022
Closed
Closed
@SWvheerden SWvheerden self-assigned this Dec 8, 2022
@SWvheerden SWvheerden moved this from Selected for development to In Progress in Tari Esme Testnet Dec 8, 2022
@SWvheerden SWvheerden mentioned this issue Dec 8, 2022
Merged
@stringhandler stringhandler moved this from In Progress to In Review in Tari Esme Testnet Dec 9, 2022
stringhandler pushed a commit that referenced this issue Jan 5, 2023
@SWvheerden
fix: console wallet spacing and naming (#5025)
e4a6303 
Description
---
Fixes the spacing of the TariAddress field in the transactions panel
Fixes the naming of the Tari address from the public key

Motivation and Context
---
These have been wrong since the update to tari address. The naming was missed when updating, and because the tari address is 2 char's longer, the spacing was out. 

How Has This Been Tested?
---
Manual


Fixes: #5018
Fixes: #5017
Fixes: #4939
@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue. E-good_first_issue Experience Level - Good for newcomers
Projects
Tari Esme Testnet
Archived in project
Milestone
Stagenet Freeze
Development

Successfully merging a pull request may close this issue.

fix: console wallet spacing and naming SWvheerden/tari
2 participants
@SWvheerden @stringhandler